RE: [PATCH] net: sctp: Rename fallthrough label to unhandled

From: Joe Perches > Sent: 01 August 2019 18:43 > On Thu, 2019-08-01 at 06:50 -0400, Neil Horman wrote: > > On Wed, Jul 31, 2019 at 03:23:46PM -0700, Joe Perches wrote: > [] > > You can say that if you want, but you made the point that your think the > > macro > > as you have written is more readab

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Fri, Aug 02, 2019 at 04:19:32PM -0700, David Miller wrote: > From: Joe Perches > Date: Fri, 02 Aug 2019 10:47:34 -0700 > > > On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote: > >> On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: > >> > On Wed, 2019-07-31 at 07:19 -0400, Neil Ho

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Fri, 2019-08-02 at 16:19 -0700, David Miller wrote: > From: Joe Perches > Date: Fri, 02 Aug 2019 10:47:34 -0700 > > > On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote: > >> On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: > >> > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wr

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Fri, 2019-08-02 at 16:19 -0700, David Miller wrote: > From: Joe Perches > Date: Fri, 02 Aug 2019 10:47:34 -0700 > > > On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote: > >> On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: > >> > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wr

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

From: Joe Perches Date: Fri, 02 Aug 2019 10:47:34 -0700 > On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote: >> On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: >> > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wrote: >> > > On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Perches w

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Perches wrote: > fallthrough may become a pseudo reserved keyword so this only use of > fallthrough is better renamed to allow it. > > Signed-off-by: Joe Perches > --- > net/sctp/sm_make_chunk.c | 12 ++-- > 1 file changed, 6 insertions(+), 6

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote: > On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: > > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wrote: > > > On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Perches wrote: > > > > fallthrough may become a pseudo reserved keyword

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Thu, Aug 01, 2019 at 10:42:31AM -0700, Joe Perches wrote: > On Thu, 2019-08-01 at 06:50 -0400, Neil Horman wrote: > > On Wed, Jul 31, 2019 at 03:23:46PM -0700, Joe Perches wrote: > [] > > You can say that if you want, but you made the point that your think the > > macro > > as you have written

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Thu, 2019-08-01 at 06:50 -0400, Neil Horman wrote: > On Wed, Jul 31, 2019 at 03:23:46PM -0700, Joe Perches wrote: [] > You can say that if you want, but you made the point that your think the macro > as you have written is more readable. You example illustrates though that /* > fallthrough */ i

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Wed, Jul 31, 2019 at 03:23:46PM -0700, Joe Perches wrote: > On Wed, 2019-07-31 at 16:58 -0400, Neil Horman wrote: > > On Wed, Jul 31, 2019 at 09:35:31AM -0700, Joe Perches wrote: > > > On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote: > > > > On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Per

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Wed, 2019-07-31 at 16:58 -0400, Neil Horman wrote: > On Wed, Jul 31, 2019 at 09:35:31AM -0700, Joe Perches wrote: > > On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote: > > > On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: > > > > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wr

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Wed, Jul 31, 2019 at 09:35:31AM -0700, Joe Perches wrote: > On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote: > > On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: > > > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wrote: > > > > On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Per

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote: > On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: > > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wrote: > > > On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Perches wrote: > > > > fallthrough may become a pseudo reserved keyword

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wrote: > > On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Perches wrote: > > > fallthrough may become a pseudo reserved keyword so this only use of > > > fallthrough is better renamed to all

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wrote: > On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Perches wrote: > > fallthrough may become a pseudo reserved keyword so this only use of > > fallthrough is better renamed to allow it. > > > > Signed-off-by: Joe Perches > Are you referring to th

Re: [PATCH] net: sctp: Rename fallthrough label to unhandled

On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Perches wrote: > fallthrough may become a pseudo reserved keyword so this only use of > fallthrough is better renamed to allow it. > > Signed-off-by: Joe Perches Are you referring to the __attribute__((fallthrough)) statement that gcc supports? If so

[PATCH] net: sctp: Rename fallthrough label to unhandled

fallthrough may become a pseudo reserved keyword so this only use of fallthrough is better renamed to allow it. Signed-off-by: Joe Perches --- net/sctp/sm_make_chunk.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chu