Re: [PATCH] net: ping: make ping_v6_sendmsg static

2016-03-23 Thread David Miller
From: 严海双 Date: Thu, 24 Mar 2016 09:53:33 +0800 > The two changes is dependent, because "pingv6_prot" and > “pingv6_protosw” must be moved to the behind also, to avoid having > to declare static “ping_v6_sendmsg” prototypes first. Agreed, and applied, thank you.

Re: [PATCH] net: ping: make ping_v6_sendmsg static

2016-03-23 Thread Sergei Shtylyov
On 3/23/2016 12:59 PM, Haishuang Yan wrote: As ping_v6_sendmsg is used only in this file, making it static The body of "pingv6_prot" and "pingv6_protosw" were moved at the middle of the file, to avoid having to declare some static prototypes. Signed-off-by: Haishuang Yan These seem as 2

[PATCH] net: ping: make ping_v6_sendmsg static

2016-03-23 Thread Haishuang Yan
As ping_v6_sendmsg is used only in this file, making it static The body of "pingv6_prot" and "pingv6_protosw" were moved at the middle of the file, to avoid having to declare some static prototypes. Signed-off-by: Haishuang Yan --- include/net/ping.h | 1 - net/ipv6/ping.c| 59