RE: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-21 Thread 劉偉權
PM To: 劉偉權 Cc: Serge Semin ; Kyle Evans ; hkallwe...@gmail.com; li...@armlinux.org.uk; da...@davemloft.net; k...@kernel.org; net...@vger.kernel.org; linux-kernel@vger.kernel.org; Ryan Kao ; Joe Hershberger ; Peter Robinson Subject: Re: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

Re: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-21 Thread Andrew Lunn
On Mon, Sep 21, 2020 at 07:00:00AM +, 劉偉權 wrote: > Hi Andrew, > I removed below register layout descriptions because these > descriptions did not match register definitions for rtl8211e > extension page 164 reg 0x1c at all. > 8:6 = PHY Address > 5:4 = Auto-Negotiation > 3 = Mode > 2 = RXD > 1

RE: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-21 Thread 劉偉權
ect: Re: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config Hello Andrew. On Fri, Sep 18, 2020 at 03:54:03PM +0200, Andrew Lunn wrote: > On Fri, Sep 18, 2020 at 06:55:16AM +, 劉偉權 wrote: > > Hi Serge, > > > Thanks for your reply. There is a confidential issue that real

Re: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-18 Thread Serge Semin
Hello Andrew. On Fri, Sep 18, 2020 at 03:54:03PM +0200, Andrew Lunn wrote: > On Fri, Sep 18, 2020 at 06:55:16AM +, 劉偉權 wrote: > > Hi Serge, > > > Thanks for your reply. There is a confidential issue that realtek > > doesn't offer the detail of a full register layout for configuration > > regi

Re: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-18 Thread Andrew Lunn
On Fri, Sep 18, 2020 at 06:55:16AM +, 劉偉權 wrote: > Hi Serge, > Thanks for your reply. There is a confidential issue that realtek > doesn't offer the detail of a full register layout for configuration > register. ... > > * 0xa4 extension page (0x7) layout. It can be used to disable/enabl

RE: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-17 Thread 劉偉權
nn.ch; hkallwe...@gmail.com; li...@armlinux.org.uk; da...@davemloft.net; k...@kernel.org; net...@vger.kernel.org; linux-kernel@vger.kernel.org; Ryan Kao ; Kyle Evans ; Joe Hershberger ; Peter Robinson Subject: Re: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config Hello Willy, Thanks for the

Re: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-17 Thread Serge Semin
Hello Willy, Thanks for the patch. My comments are below. I've Cc'ed the U-boot/FreeBSD, who might be also interested in the solution you've provided. On Thu, Sep 17, 2020 at 09:47:33AM +0800, Willy Liu wrote: > RGMII RX Delay and TX Delay settings will not applied if Force TX RX Delay > Control

[PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-16 Thread Willy Liu
RGMII RX Delay and TX Delay settings will not applied if Force TX RX Delay Control bit is not set. Register bit for configuration pins: 13 = force Tx RX Delay controlled by bit12 bit11 12 = Tx Delay 11 = Rx Delay Fixes: f81dadbcf7fd ("net: phy: realtek: Add rtl8211e rx/tx delays config") Signed-of