Re: [PATCH] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-11 Thread Sebastian Hesselbarth
On 03/11/2014 12:17 AM, Ben Hutchings wrote: On Mon, 2014-03-10 at 10:49 +, Sebastian Hesselbarth wrote: On 03/10/2014 02:51 AM, Ben Hutchings wrote: On Mon, 2014-03-10 at 02:01 +0100, Sebastian Hesselbarth wrote: phy_ethtool_get_wol is a helper to get current WOL settings from a phy devic

Re: [PATCH] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-10 Thread Ben Hutchings
On Mon, 2014-03-10 at 16:23 -0400, David Miller wrote: > From: Sebastian Hesselbarth > Date: Mon, 10 Mar 2014 10:49:53 + > > > void phy_ethtool_get_wol(struct phy_device *phydev, struct > > ethtool_wolinfo *wol) > > { > > memset(wol, 0, sizeof(*wol)); > > > > if (phydev && phydev

Re: [PATCH] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-10 Thread Ben Hutchings
On Mon, 2014-03-10 at 10:49 +, Sebastian Hesselbarth wrote: > On 03/10/2014 02:51 AM, Ben Hutchings wrote: > > On Mon, 2014-03-10 at 02:01 +0100, Sebastian Hesselbarth wrote: > >> phy_ethtool_get_wol is a helper to get current WOL settings from > >> a phy device. When using this helper on a PHY

Re: [PATCH] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-10 Thread David Miller
From: Sebastian Hesselbarth Date: Mon, 10 Mar 2014 10:49:53 + > void phy_ethtool_get_wol(struct phy_device *phydev, struct > ethtool_wolinfo *wol) > { > memset(wol, 0, sizeof(*wol)); > > if (phydev && phydev->drv->get_wol) > phydev->drv->get_wol(phydev, wol); > } >

Re: [PATCH] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-10 Thread Sebastian Hesselbarth
On 03/10/2014 02:51 AM, Ben Hutchings wrote: On Mon, 2014-03-10 at 02:01 +0100, Sebastian Hesselbarth wrote: phy_ethtool_get_wol is a helper to get current WOL settings from a phy device. When using this helper on a PHY without .get_wol callback, struct ethtool_wolinfo is never set-up correctly

Re: [PATCH] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-09 Thread Ben Hutchings
On Mon, 2014-03-10 at 02:01 +0100, Sebastian Hesselbarth wrote: > phy_ethtool_get_wol is a helper to get current WOL settings from > a phy device. When using this helper on a PHY without .get_wol > callback, struct ethtool_wolinfo is never set-up correctly and > may contain misleading information a

[PATCH] net: phy: fix uninitalized WOL parameters in phy_ethtool_get_wol

2014-03-09 Thread Sebastian Hesselbarth
phy_ethtool_get_wol is a helper to get current WOL settings from a phy device. When using this helper on a PHY without .get_wol callback, struct ethtool_wolinfo is never set-up correctly and may contain misleading information about WOL status. To fix this, always zero relevant fields of struct eth