Re: [PATCH] net: mlx5: remove pointless memcpy

2018-02-02 Thread Saeed Mahameed
On 02/02/2018 12:26 PM, Arnd Bergmann wrote: > On Fri, Feb 2, 2018 at 8:06 PM, Jason Gunthorpe wrote: >> On Fri, Feb 02, 2018 at 04:46:30PM +0100, Arnd Bergmann wrote: >>> gcc-8 notices that the memcpy in mlx5_core_query_xsrq() makes no >>> sense because the source and destination variables are

Re: [PATCH] net: mlx5: remove pointless memcpy

2018-02-02 Thread Arnd Bergmann
On Fri, Feb 2, 2018 at 8:06 PM, Jason Gunthorpe wrote: > On Fri, Feb 02, 2018 at 04:46:30PM +0100, Arnd Bergmann wrote: >> gcc-8 notices that the memcpy in mlx5_core_query_xsrq() makes no >> sense because the source and destination variables are identical: >> >> drivers/net/ethernet/mellanox/mlx5/

Re: [PATCH] net: mlx5: remove pointless memcpy

2018-02-02 Thread Jason Gunthorpe
On Fri, Feb 02, 2018 at 04:46:30PM +0100, Arnd Bergmann wrote: > gcc-8 notices that the memcpy in mlx5_core_query_xsrq() makes no > sense because the source and destination variables are identical: > > drivers/net/ethernet/mellanox/mlx5/core/transobj.c: In function > 'mlx5_core_query_xsrq': > dri

[PATCH] net: mlx5: remove pointless memcpy

2018-02-02 Thread Arnd Bergmann
gcc-8 notices that the memcpy in mlx5_core_query_xsrq() makes no sense because the source and destination variables are identical: drivers/net/ethernet/mellanox/mlx5/core/transobj.c: In function 'mlx5_core_query_xsrq': drivers/net/ethernet/mellanox/mlx5/core/transobj.c:347:3: error: 'memcpy' sou