Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:34:04PM +0200, Jan Moskyto Matejka wrote: > On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > > From: Jan Moskyto Matejka > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > > > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > > > +int rt6_dump_route(s

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 10:26:08AM -0700, David Ahern wrote: > On 5/12/17 8:24 AM, David Miller wrote: > > From: Jan Moskyto Matejka > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > >> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > >> +int rt6_dump_route(struct rt6_info *rt, void *p_arg,

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > From: Jan Moskyto Matejka > Date: Fri, 12 May 2017 13:15:10 +0200 > > > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > > +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate); > > Please use "bool" and "true"

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread David Miller
From: David Ahern Date: Fri, 12 May 2017 10:26:08 -0700 > On 5/12/17 8:24 AM, David Miller wrote: >> From: Jan Moskyto Matejka >> Date: Fri, 12 May 2017 13:15:10 +0200 >> >>> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); >>> +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int tru

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread David Ahern
On 5/12/17 8:24 AM, David Miller wrote: > From: Jan Moskyto Matejka > Date: Fri, 12 May 2017 13:15:10 +0200 > >> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); >> +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate); > > Please use "bool" and "true"/"false" for boolean val

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread David Miller
From: Jan Moskyto Matejka Date: Fri, 12 May 2017 13:15:10 +0200 > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate); Please use "bool" and "true"/"false" for boolean values. What does ipv4 do in this situation? I'm hesi

[PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
When rt6_fill_node() fails to fit the route into the buffer, it drops the route, returns -EMSGSIZE and waits for buffer flush. This condition is detected by non-null return value and non-empty buffer; the buffer is flushed and rt6_fill_node() restarted. However, when a single route generates such