Re: [PATCH] net: fec: Fix multicast list setup in fec_restart().

2013-06-27 Thread Fabio Estevam
On Thu, Jun 27, 2013 at 2:14 PM, Christoph Müllner wrote: > Is updated in the attached patch. > Thank you for the feedback! Looks good. Some suggestions: - Mark the patch as the second version: Subject: [PATCH v2] net: fec: Fix multicast list setup in fec_restart(). - Add a comment below the

Re: [PATCH] net: fec: Fix multicast list setup in fec_restart().

2013-06-27 Thread Christoph Müllner
On Jun 21, 2013, at 7:15 PM, Fabio Estevam wrote: > On Fri, Jun 21, 2013 at 1:40 PM, Christoph Müllner > wrote: > >> @@ -472,8 +474,7 @@ fec_restart(struct net_device *ndev, int duplex) >>writel(0xffc0, fep->hwp + FEC_IEVENT); >> >>/* Reset all multicast. */ > > Should thi

Re: [PATCH] net: fec: Fix multicast list setup in fec_restart().

2013-06-21 Thread Joe Perches
On Fri, 2013-06-21 at 18:40 +0200, Christoph Müllner wrote: > Setup the multicast list of the net_device instead of > clearing it blindly. This restores the multicast groups > in case of a link down/up event. > > Signed-off-by: Christoph Muellner Theobroma? food of the gods or does your company

Re: [PATCH] net: fec: Fix multicast list setup in fec_restart().

2013-06-21 Thread Fabio Estevam
On Fri, Jun 21, 2013 at 1:40 PM, Christoph Müllner wrote: > @@ -472,8 +474,7 @@ fec_restart(struct net_device *ndev, int duplex) > writel(0xffc0, fep->hwp + FEC_IEVENT); > > /* Reset all multicast. */ Should this comment be removed/updated now? > - writel(0, fep->hwp +

[PATCH] net: fec: Fix multicast list setup in fec_restart().

2013-06-21 Thread Christoph Müllner
Setup the multicast list of the net_device instead of clearing it blindly. This restores the multicast groups in case of a link down/up event. Signed-off-by: Christoph Muellner --- drivers/net/ethernet/freescale/fec_main.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --gi