Re: [PATCH] net: ethernet: broadcom: bnx2x: Remove redundant #ifdef

2014-08-22 Thread David Miller
From: Rasmus Villemoes Date: Fri, 22 Aug 2014 09:33:07 +0200 > David Miller writes: > >> From: Rasmus Villemoes >> Date: Wed, 20 Aug 2014 15:14:49 +0200 >> >>> Nothing defines _ASM_GENERIC_INT_L64_H, it is a weird way to check for >>> 64 bit longs, and u64 should be printed using %llx anyway.

Re: [PATCH] net: ethernet: broadcom: bnx2x: Remove redundant #ifdef

2014-08-22 Thread Rasmus Villemoes
David Miller writes: > From: Rasmus Villemoes > Date: Wed, 20 Aug 2014 15:14:49 +0200 > >> Nothing defines _ASM_GENERIC_INT_L64_H, it is a weird way to check for >> 64 bit longs, and u64 should be printed using %llx anyway. >> >> Signed-off-by: Rasmus Villemoes > > It's not correct and will wa

Re: [PATCH] net: ethernet: broadcom: bnx2x: Remove redundant #ifdef

2014-08-21 Thread David Miller
From: Rasmus Villemoes Date: Wed, 20 Aug 2014 15:14:49 +0200 > Nothing defines _ASM_GENERIC_INT_L64_H, it is a weird way to check for > 64 bit longs, and u64 should be printed using %llx anyway. > > Signed-off-by: Rasmus Villemoes It's not correct and will warn on some platforms where "u64" is

[PATCH] net: ethernet: broadcom: bnx2x: Remove redundant #ifdef

2014-08-20 Thread Rasmus Villemoes
Nothing defines _ASM_GENERIC_INT_L64_H, it is a weird way to check for 64 bit longs, and u64 should be printed using %llx anyway. Signed-off-by: Rasmus Villemoes --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/broadc