Re: [PATCH] net/sctp: fix GCC8+ -Wpacked-not-aligned warnings

2019-07-29 Thread Qian Cai
On Mon, 2019-07-29 at 10:39 +, David Laight wrote: > From: Qian Cai > > Sent: 26 July 2019 21:58 > > > > There are a lot of those warnings with GCC8+ 64bit, > > > > ... > > Fix them by aligning the structures and fields to 8 bytes instead. > > ... > >  struct sctp_setpeerprim { > >   sctp

RE: [PATCH] net/sctp: fix GCC8+ -Wpacked-not-aligned warnings

2019-07-29 Thread David Laight
From: Qian Cai > Sent: 26 July 2019 21:58 > > There are a lot of those warnings with GCC8+ 64bit, > ... > Fix them by aligning the structures and fields to 8 bytes instead. ... > struct sctp_setpeerprim { > sctp_assoc_tsspp_assoc_id; > - struct sockaddr_storage sspp_addr; >

Re: [PATCH] net/sctp: fix GCC8+ -Wpacked-not-aligned warnings

2019-07-28 Thread Marcelo Ricardo Leitner
On Sun, Jul 28, 2019 at 01:05:25PM -0400, Qian Cai wrote: > > > > On Jul 26, 2019, at 5:30 PM, Marcelo Ricardo Leitner > > wrote: > > > > On Fri, Jul 26, 2019 at 04:57:39PM -0400, Qian Cai wrote: > >> There are a lot of those warnings with GCC8+ 64bit, > >> > >> In file included from ./includ

Re: [PATCH] net/sctp: fix GCC8+ -Wpacked-not-aligned warnings

2019-07-28 Thread Qian Cai
> On Jul 26, 2019, at 5:30 PM, Marcelo Ricardo Leitner > wrote: > > On Fri, Jul 26, 2019 at 04:57:39PM -0400, Qian Cai wrote: >> There are a lot of those warnings with GCC8+ 64bit, >> >> In file included from ./include/linux/sctp.h:42, >> from net/core/skbuff.c:47: >> ./inclu

Re: [PATCH] net/sctp: fix GCC8+ -Wpacked-not-aligned warnings

2019-07-26 Thread Marcelo Ricardo Leitner
On Fri, Jul 26, 2019 at 04:57:39PM -0400, Qian Cai wrote: > There are a lot of those warnings with GCC8+ 64bit, > > In file included from ./include/linux/sctp.h:42, > from net/core/skbuff.c:47: > ./include/uapi/linux/sctp.h:395:1: warning: alignment 4 of 'struct > sctp_paddr_chang

[PATCH] net/sctp: fix GCC8+ -Wpacked-not-aligned warnings

2019-07-26 Thread Qian Cai
There are a lot of those warnings with GCC8+ 64bit, In file included from ./include/linux/sctp.h:42, from net/core/skbuff.c:47: ./include/uapi/linux/sctp.h:395:1: warning: alignment 4 of 'struct sctp_paddr_change' is less than 8 [-Wpacked-not-aligned] } __attribute__((packed, ali