Re: [PATCH] net/rfkill: Create "airplane mode" LED trigger

2016-01-07 Thread João Paulo Rechi Vita
+ Darren Hart and platform-drivers-x86 (sorry, I was trying to avoid too much cross-posting and ended up leaving interested parties out). On 6 Jan 2016 05:32, "Johannes Berg" wrote: > > On Tue, 2016-01-05 at 22:55 -0800, Marcel Holtmann wrote: > > > > so I am not convinced the kernel should have

Re: [PATCH] net/rfkill: Create "airplane mode" LED trigger

2016-01-06 Thread Johannes Berg
On Tue, 2016-01-05 at 22:55 -0800, Marcel Holtmann wrote: >  > so I am not convinced the kernel should have the concept of airplane > mode at all. [snip long story] This is true, but that doesn't mean the patch is bad, just the naming could be different. I think the patch could name this "rfkill

Re: [PATCH] net/rfkill: Create "airplane mode" LED trigger

2016-01-05 Thread Marcel Holtmann
Hi Joao, > For platform drivers to be able to correctly drive the "Airplane Mode" > indicative LED there needs to be a RFKill LED trigger tied to the global > state of RFKILL_TYPE_ALL (instead of to a specific RFKill) and that > works in an inverted manner of regular RFKill LED triggers, that is,

Re: [PATCH] net/rfkill: Create "airplane mode" LED trigger

2016-01-05 Thread João Paulo Rechi Vita
Hello Johannes, On 26 December 2015 at 10:05, João Paulo Rechi Vita wrote: > For platform drivers to be able to correctly drive the "Airplane Mode" > indicative LED there needs to be a RFKill LED trigger tied to the global > state of RFKILL_TYPE_ALL (instead of to a specific RFKill) and that > wo

[PATCH] net/rfkill: Create "airplane mode" LED trigger

2015-12-26 Thread João Paulo Rechi Vita
For platform drivers to be able to correctly drive the "Airplane Mode" indicative LED there needs to be a RFKill LED trigger tied to the global state of RFKILL_TYPE_ALL (instead of to a specific RFKill) and that works in an inverted manner of regular RFKill LED triggers, that is, the LED is ON when