Re: [PATCH] net/mlx5e: remove h from printk format specifier

2021-01-05 Thread Saeed Mahameed
On Wed, 2020-12-23 at 11:45 -0800, t...@redhat.com wrote: > From: Tom Rix > > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is already d

Re: [PATCH] net/mlx5e: remove h from printk format specifier

2020-12-23 Thread Leon Romanovsky
On Wed, Dec 23, 2020 at 11:45:12AM -0800, t...@redhat.com wrote: > From: Tom Rix > > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of > unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is alr

[PATCH] net/mlx5e: remove h from printk format specifier

2020-12-23 Thread trix
From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi