Re: [PATCH] net/mlx5e: Fix freeing of unassigned pointer

2020-10-07 Thread Alex Dewar
On Tue, Oct 06, 2020 at 04:22:12PM -0700, Saeed Mahameed wrote: > On Sat, 2020-10-03 at 12:10 +0100, Alex Dewar wrote: > > Commit ff7ea04ad579 ("net/mlx5e: Fix potential null pointer > > dereference") > > added some missing null checks but the error handling in > > mlx5e_alloc_flow() was left broke

Re: [PATCH] net/mlx5e: Fix freeing of unassigned pointer

2020-10-06 Thread Saeed Mahameed
On Sat, 2020-10-03 at 12:10 +0100, Alex Dewar wrote: > Commit ff7ea04ad579 ("net/mlx5e: Fix potential null pointer > dereference") > added some missing null checks but the error handling in > mlx5e_alloc_flow() was left broken: the variable attr is passed to > kfree > although it is never assigned

[PATCH] net/mlx5e: Fix freeing of unassigned pointer

2020-10-03 Thread Alex Dewar
Commit ff7ea04ad579 ("net/mlx5e: Fix potential null pointer dereference") added some missing null checks but the error handling in mlx5e_alloc_flow() was left broken: the variable attr is passed to kfree although it is never assigned to and never needs to be freed in this function. Fix this. Addre