Re: [PATCH] net/ipv4 debug cleanup, kernel 2.6.13-rc5

2005-08-10 Thread Heikki Orsila
On Wed, Aug 10, 2005 at 03:09:34AM +0200, Patrick McHardy wrote: > These macros always looked a bit ugly to me, with your cleanup there > isn't a single spot left where we require them to accept code as > argument, so how about we change them to pure printk wrappers? Sounds like a good idea. --

Re: [PATCH] net/ipv4 debug cleanup, kernel 2.6.13-rc5

2005-08-09 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 10 Aug 2005 03:09:34 +0200 > These macros always looked a bit ugly to me, with your cleanup there > isn't a single spot left where we require them to accept code as > argument, so how about we change them to pure printk wrappers? Applied to 2.6

Re: [PATCH] net/ipv4 debug cleanup, kernel 2.6.13-rc5

2005-08-09 Thread Patrick McHardy
Heikki Orsila wrote: > Here's a small patch to cleanup NETDEBUG() use in net/ipv4/ for Linux > kernel 2.6.13-rc5. Also weird use of indentation is changed in some > places. > > --- > diff -urp linux-2.6.13-rc5-org/net/ipv4/icmp.c > linux-2.6.13-rc5/net/ipv4/icmp.c > --- linux-2.6.13-rc5-org/net/

[PATCH] net/ipv4 debug cleanup, kernel 2.6.13-rc5

2005-08-07 Thread Heikki Orsila
Here's a small patch to cleanup NETDEBUG() use in net/ipv4/ for Linux kernel 2.6.13-rc5. Also weird use of indentation is changed in some places. Signed-off-by: Heikki Orsila <[EMAIL PROTECTED]> --- diff -urp linux-2.6.13-rc5-org/net/ipv4/icmp.c linux-2.6.13-rc5/net/ipv4/icmp.c --- linux-2.6.13-