Re: [PATCH] net/core: Use RCU_INIT_POINTER(x, NULL) in netpoll.c

2014-03-27 Thread Paul E. McKenney
On Mon, Mar 24, 2014 at 07:11:44AM -0400, Neil Horman wrote: > On Mon, Mar 24, 2014 at 12:42:46AM +0530, Monam Agarwal wrote: > > This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, > > NULL) > > > > The rcu_assign_pointer() ensures that the initialization of a structure

Re: [PATCH] net/core: Use RCU_INIT_POINTER(x, NULL) in netpoll.c

2014-03-25 Thread David Miller
From: Monam Agarwal Date: Mon, 24 Mar 2014 00:42:46 +0530 > This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) > > The rcu_assign_pointer() ensures that the initialization of a structure > is carried out before storing a pointer to that structure. > And in the

Re: [PATCH] net/core: Use RCU_INIT_POINTER(x, NULL) in netpoll.c

2014-03-24 Thread Neil Horman
On Mon, Mar 24, 2014 at 06:14:35AM -0700, Eric Dumazet wrote: > On Mon, 2014-03-24 at 07:11 -0400, Neil Horman wrote: > > On Mon, Mar 24, 2014 at 12:42:46AM +0530, Monam Agarwal wrote: > > > This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, > > > NULL) > > > > > > The rcu_a

Re: [PATCH] net/core: Use RCU_INIT_POINTER(x, NULL) in netpoll.c

2014-03-24 Thread Eric Dumazet
On Mon, 2014-03-24 at 07:11 -0400, Neil Horman wrote: > On Mon, Mar 24, 2014 at 12:42:46AM +0530, Monam Agarwal wrote: > > This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, > > NULL) > > > > The rcu_assign_pointer() ensures that the initialization of a structure > >

Re: [PATCH] net/core: Use RCU_INIT_POINTER(x, NULL) in netpoll.c

2014-03-24 Thread Neil Horman
On Mon, Mar 24, 2014 at 12:42:46AM +0530, Monam Agarwal wrote: > This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) > > The rcu_assign_pointer() ensures that the initialization of a structure > is carried out before storing a pointer to that structure. > And in

[PATCH] net/core: Use RCU_INIT_POINTER(x, NULL) in netpoll.c

2014-03-23 Thread Monam Agarwal
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure. And in the case of the NULL pointer, there is no structure to initialize. So, r