Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Julien Grall
On 06/07/15 12:19, Florian Westphal wrote: > Julien Grall wrote: >> On 03/07/15 21:42, Florian Westphal wrote: >>> I think it makes more sense to use __in6_dev_get() instead which doesn't >>> take a reference. >> >> __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on >> this code

Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Florian Westphal
Julien Grall wrote: > On 03/07/15 21:42, Florian Westphal wrote: > > I think it makes more sense to use __in6_dev_get() instead which doesn't > > take a reference. > > __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on > this code is very limited. Are we sure that one this lock

Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Eric Dumazet
On Mon, 2015-07-06 at 11:35 +0100, Julien Grall wrote: > __in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge on > this code is very limited. Are we sure that one this lock is hold? At > first glance, I wasn't able to find one. You could play it safe ;) diff --git a/net/bridge/br_n

Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Julien Grall
Hi, On 03/07/15 21:42, Florian Westphal wrote: > Julien Grall wrote: >> The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge: >> forward IPv6 fragmented packets" introduced a new function >> br_validate_ipv6 which take a reference on the inet6 device. Although, >> the reference

Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Bob Liu
On 07/04/2015 02:01 AM, Julien Grall wrote: > The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge: > forward IPv6 fragmented packets" introduced a new function > br_validate_ipv6 which take a reference on the inet6 device. Although, > the reference is not released at the end. >

Re: [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-03 Thread Florian Westphal
Julien Grall wrote: > The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge: > forward IPv6 fragmented packets" introduced a new function > br_validate_ipv6 which take a reference on the inet6 device. Although, > the reference is not released at the end. > > This will result to t

[PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-03 Thread Julien Grall
The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd "netfilter: bridge: forward IPv6 fragmented packets" introduced a new function br_validate_ipv6 which take a reference on the inet6 device. Although, the reference is not released at the end. This will result to the impossibility to destroy any n