Re: [PATCH] nd_btt: Make BTT lanes preemptible

2023-09-19 Thread Tomas Glozar
po 18. 9. 2023 v 23:32 odesílatel Ira Weiny napsal: > Thanks for clarifying. Could you respin the patch with the text below? > That would have saved me a lot of time digging to see what the code path > was. Sent v2 with relevant parts of the BUG message.

Re: [PATCH] nd_btt: Make BTT lanes preemptible

2023-09-18 Thread Ira Weiny
Tomas Glozar wrote: > čt 14. 9. 2023 v 22:18 odesílatel Ira Weiny napsal: > > Is the bug in 1 of 2 places? > > > > 1) When btt_write_pg()->lock_map() (when the number of lanes is < number > >of cpus) and the lane is acquired is called? > > > > *or* > > > > 2) When nd_region_acquire_lane() inte

Re: [PATCH] nd_btt: Make BTT lanes preemptible

2023-09-17 Thread Tomas Glozar
čt 14. 9. 2023 v 22:18 odesílatel Ira Weiny napsal: > Is the bug in 1 of 2 places? > > 1) When btt_write_pg()->lock_map() (when the number of lanes is < number >of cpus) and the lane is acquired is called? > > *or* > > 2) When nd_region_acquire_lane() internally trys to take it's lock? > > A c

Re: [PATCH] nd_btt: Make BTT lanes preemptible

2023-09-14 Thread Ira Weiny
Tomáš Glozar wrote: > From: Tomas Glozar > > nd_region_acquire_lane uses get_cpu, which disables preemption. This is > an issue on PREEMPT_RT kernels, since btt_write_pg and also > nd_region_acquire_lane itself take a spin lock, resulting in BUG: > sleeping function called from invalid context.

[PATCH] nd_btt: Make BTT lanes preemptible

2023-09-12 Thread Tomáš Glozar
From: Tomas Glozar nd_region_acquire_lane uses get_cpu, which disables preemption. This is an issue on PREEMPT_RT kernels, since btt_write_pg and also nd_region_acquire_lane itself take a spin lock, resulting in BUG: sleeping function called from invalid context. Fix the issue by replacing get_c