Re: [PATCH] mtd_blkdevs: Convert to use the kthread API

2007-04-22 Thread Christoph Hellwig
On Sun, Apr 22, 2007 at 01:24:53PM +0100, Christoph Hellwig wrote: > On Thu, Apr 19, 2007 at 12:55:28AM -0600, Eric W. Biederman wrote: > > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > > > thread_run is used intead of kernel_thread, daemonize, and mucking > > around blocking signals

Re: [PATCH] mtd_blkdevs: Convert to use the kthread API

2007-04-22 Thread Christoph Hellwig
On Sun, Apr 22, 2007 at 02:23:00PM +0100, David Woodhouse wrote: > On Sun, 2007-04-22 at 13:24 +0100, Christoph Hellwig wrote: > > This is the full conversion I sent to Dave in April 2006, but never > > got any feedback to: > > Sorry about that; I need prodding sometimes. I'll provide some now...

Re: [PATCH] mtd_blkdevs: Convert to use the kthread API

2007-04-22 Thread David Woodhouse
On Sun, 2007-04-22 at 13:24 +0100, Christoph Hellwig wrote: > This is the full conversion I sent to Dave in April 2006, but never > got any feedback to: Sorry about that; I need prodding sometimes. I'll provide some now... Can you show me why the thread won't now miss a wakeup if it goes to slee

Re: [PATCH] mtd_blkdevs: Convert to use the kthread API

2007-04-22 Thread Christoph Hellwig
On Thu, Apr 19, 2007 at 12:55:28AM -0600, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > thread_run is used intead of kernel_thread, daemonize, and mucking > around blocking signals directly. This is the full conversion I sent to Dave in April 2006, but neve

Re: [PATCH] mtd_blkdevs: Convert to use the kthread API

2007-04-19 Thread Andrew Morton
On Thu, 19 Apr 2007 13:13:22 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > Christoph Hellwig <[EMAIL PROTECTED]> writes: > > > On Thu, Apr 19, 2007 at 12:55:28AM -0600, Eric W. Biederman wrote: > >> From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > >> > >> thread_run is used intead

Re: [PATCH] mtd_blkdevs: Convert to use the kthread API

2007-04-19 Thread Eric W. Biederman
Christoph Hellwig <[EMAIL PROTECTED]> writes: > On Thu, Apr 19, 2007 at 12:55:28AM -0600, Eric W. Biederman wrote: >> From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted >> >> thread_run is used intead of kernel_thread, daemonize, and mucking >> around blocking signals directly. > > Please don

Re: [PATCH] mtd_blkdevs: Convert to use the kthread API

2007-04-19 Thread Christoph Hellwig
On Thu, Apr 19, 2007 at 12:55:28AM -0600, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > thread_run is used intead of kernel_thread, daemonize, and mucking > around blocking signals directly. Please don't do incomplete transitions like that. We don't really

[PATCH] mtd_blkdevs: Convert to use the kthread API

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> thread_run is used intead of kernel_thread, daemonize, and mucking around blocking signals directly. CC: David Woodhouse <[EMAIL PROTECTED]> Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/mtd/mtd_blkdevs.c | 19 +--

[PATCH] mtd_blkdevs: Convert to use the kthread API

2007-04-19 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted thread_run is used intead of kernel_thread, daemonize, and mucking around blocking signals directly. CC: David Woodhouse <[EMAIL PROTECTED]> Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- drivers/mtd/mtd_blkdevs.c | 19 +-