Re: [PATCH] mtd: sa1100: avoid VLA in sa1100_setup_mtd

2018-10-29 Thread Arnd Bergmann
On Mon, Oct 29, 2018 at 8:30 AM Boris Brezillon wrote: > On Sun, 28 Oct 2018 19:13:26 -0700 Kees Cook wrote: > > On Fri, Oct 12, 2018 at 2:22 AM, Boris Brezillon > > wrote: > > > On Fri, 12 Oct 2018 11:19:52 +0200 Arnd Bergmann wrote: > > > > On Fri, Oct 12, 2018 at 11:16 AM Boris Brezillon >

Re: [PATCH] mtd: sa1100: avoid VLA in sa1100_setup_mtd

2018-10-29 Thread Boris Brezillon
Hi Kees, On Sun, 28 Oct 2018 19:13:26 -0700 Kees Cook wrote: > On Fri, Oct 12, 2018 at 2:22 AM, Boris Brezillon > wrote: > > On Fri, 12 Oct 2018 11:19:52 +0200 > > Arnd Bergmann wrote: > > > >> On Fri, Oct 12, 2018 at 11:16 AM Boris Brezillon > >> wrote: > >> > > >> > Hi Arnd, > >> > > >>

Re: [PATCH] mtd: sa1100: avoid VLA in sa1100_setup_mtd

2018-10-28 Thread Kees Cook
On Fri, Oct 12, 2018 at 2:22 AM, Boris Brezillon wrote: > On Fri, 12 Oct 2018 11:19:52 +0200 > Arnd Bergmann wrote: > >> On Fri, Oct 12, 2018 at 11:16 AM Boris Brezillon >> wrote: >> > >> > Hi Arnd, >> > >> > On Wed, 10 Oct 2018 20:44:50 +0200 >> > Arnd Bergmann wrote: >> > >> > > Enabling -Wvl

Re: [PATCH] mtd: sa1100: avoid VLA in sa1100_setup_mtd

2018-10-12 Thread Boris Brezillon
On Fri, 12 Oct 2018 11:19:52 +0200 Arnd Bergmann wrote: > On Fri, Oct 12, 2018 at 11:16 AM Boris Brezillon > wrote: > > > > Hi Arnd, > > > > On Wed, 10 Oct 2018 20:44:50 +0200 > > Arnd Bergmann wrote: > > > > > Enabling -Wvla found another variable-length array with randconfig > > > testing:

Re: [PATCH] mtd: sa1100: avoid VLA in sa1100_setup_mtd

2018-10-12 Thread Arnd Bergmann
On Fri, Oct 12, 2018 at 11:16 AM Boris Brezillon wrote: > > Hi Arnd, > > On Wed, 10 Oct 2018 20:44:50 +0200 > Arnd Bergmann wrote: > > > Enabling -Wvla found another variable-length array with randconfig > > testing: > > > > drivers/mtd/maps/sa1100-flash.c: In function 'sa1100_setup_mtd': > > dri

Re: [PATCH] mtd: sa1100: avoid VLA in sa1100_setup_mtd

2018-10-12 Thread Boris Brezillon
Hi Arnd, On Wed, 10 Oct 2018 20:44:50 +0200 Arnd Bergmann wrote: > Enabling -Wvla found another variable-length array with randconfig > testing: > > drivers/mtd/maps/sa1100-flash.c: In function 'sa1100_setup_mtd': > drivers/mtd/maps/sa1100-flash.c:224:10: error: ISO C90 forbids variable > leng

[PATCH] mtd: sa1100: avoid VLA in sa1100_setup_mtd

2018-10-10 Thread Arnd Bergmann
Enabling -Wvla found another variable-length array with randconfig testing: drivers/mtd/maps/sa1100-flash.c: In function 'sa1100_setup_mtd': drivers/mtd/maps/sa1100-flash.c:224:10: error: ISO C90 forbids variable length array 'cdev' [-Werror=vla] As far as I can tell, there is an upper bound on