Re: [PATCH] mtd: s3c2410: add device tree support

2016-09-25 Thread Boris Brezillon
Hi Sergio, On Sun, 25 Sep 2016 14:42:57 -0300 Sergio Prado wrote: > Hi Boris, > > > > +Optional properties: > > > +- samsung,tacls : time for active CLE/ALE to nWE/nOE > > > +- samsung,twrph0 : active time for nWE/nOE > > > +- samsung,twrph1 : time for release CLE/ALE from nWE/nOE inactive >

Re: [PATCH] mtd: s3c2410: add device tree support

2016-09-25 Thread Sergio Prado
Hi Boris, > > +Optional properties: > > +- samsung,tacls : time for active CLE/ALE to nWE/nOE > > +- samsung,twrph0 : active time for nWE/nOE > > +- samsung,twrph1 : time for release CLE/ALE from nWE/nOE inactive > > Can you try to extract these information from the nand_sdr_timings > struct inst

Re: [PATCH] mtd: s3c2410: add device tree support

2016-09-23 Thread Rob Herring
On Sat, Sep 17, 2016 at 12:22:40PM -0300, Sergio Prado wrote: > Tested on FriendlyARM Mini2440 > > Signed-off-by: Sergio Prado > --- > .../devicetree/bindings/mtd/samsung-s3c2410.txt| 70 +++ > drivers/mtd/nand/s3c2410.c | 129 > - > incl

Re: [PATCH] mtd: s3c2410: add device tree support

2016-09-19 Thread Sergio Prado
On Mon, Sep 19, 2016 at 12:44:07PM +0200, Sylwester Nawrocki wrote: > On 09/17/2016 05:22 PM, Sergio Prado wrote: > > +static int s3c24xx_nand_probe_dt(struct platform_device *pdev) > > +{ > > + const struct s3c24XX_nand_devtype_data *devtype_data; > > + struct s3c2410_platform_nand *pdata; > >

Re: [PATCH] mtd: s3c2410: add device tree support

2016-09-19 Thread Sergio Prado
On Mon, Sep 19, 2016 at 10:11:55AM +0100, Mark Rutland wrote: > On Sat, Sep 17, 2016 at 12:22:40PM -0300, Sergio Prado wrote: > > Tested on FriendlyARM Mini2440 > > > > Signed-off-by: Sergio Prado > > --- > > .../devicetree/bindings/mtd/samsung-s3c2410.txt| 70 +++ > > drivers/mtd/n

Re: [PATCH] mtd: s3c2410: add device tree support

2016-09-19 Thread Sergio Prado
On Sat, Sep 17, 2016 at 07:31:23PM +0200, Boris Brezillon wrote: > Hi Sergio, > > On Sat, 17 Sep 2016 12:22:40 -0300 > Sergio Prado wrote: > > > Tested on FriendlyARM Mini2440 > > > > Signed-off-by: Sergio Prado > > --- > > .../devicetree/bindings/mtd/samsung-s3c2410.txt| 70 +++

Re: [PATCH] mtd: s3c2410: add device tree support

2016-09-19 Thread Sylwester Nawrocki
On 09/17/2016 05:22 PM, Sergio Prado wrote: > +static int s3c24xx_nand_probe_dt(struct platform_device *pdev) > +{ > + const struct s3c24XX_nand_devtype_data *devtype_data; > + struct s3c2410_platform_nand *pdata; > + struct s3c2410_nand_info *info = platform_get_drvdata(pdev); > +

Re: [PATCH] mtd: s3c2410: add device tree support

2016-09-19 Thread Mark Rutland
On Sat, Sep 17, 2016 at 12:22:40PM -0300, Sergio Prado wrote: > Tested on FriendlyARM Mini2440 > > Signed-off-by: Sergio Prado > --- > .../devicetree/bindings/mtd/samsung-s3c2410.txt| 70 +++ > drivers/mtd/nand/s3c2410.c | 129 > - > incl

Re: [PATCH] mtd: s3c2410: add device tree support

2016-09-17 Thread Boris Brezillon
Hi Sergio, On Sat, 17 Sep 2016 12:22:40 -0300 Sergio Prado wrote: > Tested on FriendlyARM Mini2440 > > Signed-off-by: Sergio Prado > --- > .../devicetree/bindings/mtd/samsung-s3c2410.txt| 70 +++ DT maintainers usually ask people to keep the DT bindings doc in a separate patch.

[PATCH] mtd: s3c2410: add device tree support

2016-09-17 Thread Sergio Prado
Tested on FriendlyARM Mini2440 Signed-off-by: Sergio Prado --- .../devicetree/bindings/mtd/samsung-s3c2410.txt| 70 +++ drivers/mtd/nand/s3c2410.c | 129 - include/linux/platform_data/mtd-nand-s3c2410.h | 1 + 3 files changed, 195 in