Re: [PATCH] mtd: rawnand: tegra: check bounds of die_nr properly

2018-07-12 Thread Dan Carpenter
On Thu, Jul 12, 2018 at 01:31:57PM +, Marcel Ziswiler wrote: > On Wed, 2018-07-04 at 11:13 +0200, Stefan Agner wrote: > > The Tegra driver currently only support a single chip select, hence > > check boundaries accordingly. This fixes a off by one issue catched > > with Smatch: > > drivers/

Re: [PATCH] mtd: rawnand: tegra: check bounds of die_nr properly

2018-07-12 Thread Marcel Ziswiler
On Wed, 2018-07-04 at 11:13 +0200, Stefan Agner wrote: > The Tegra driver currently only support a single chip select, hence > check boundaries accordingly. This fixes a off by one issue catched > with Smatch: > drivers/mtd/nand/raw/tegra_nand.c:476 tegra_nand_select_chip() > warn: array of

Re: [PATCH] mtd: rawnand: tegra: check bounds of die_nr properly

2018-07-08 Thread Miquel Raynal
Hi Stefan, Stefan Agner wrote on Wed, 4 Jul 2018 11:13:10 +0200: > The Tegra driver currently only support a single chip select, hence > check boundaries accordingly. This fixes a off by one issue catched > with Smatch: > drivers/mtd/nand/raw/tegra_nand.c:476 tegra_nand_select_chip() >

[PATCH] mtd: rawnand: tegra: check bounds of die_nr properly

2018-07-04 Thread Stefan Agner
The Tegra driver currently only support a single chip select, hence check boundaries accordingly. This fixes a off by one issue catched with Smatch: drivers/mtd/nand/raw/tegra_nand.c:476 tegra_nand_select_chip() warn: array off by one? 'nand->cs[die_nr]' Also warn in case the stack asks fo