Re: [PATCH] mtd: rawnand: ingenic: Fix build error

2019-06-15 Thread Paul Cercueil
Hi, I don't think the patch is correct. We want to be able to build the ingenic_nand driver without the ingenic_ecc code. The actual problem is that if the ingenic_nand driver is built-in, then the ingenic_ecc driver must be built-in too (if enabled), and we don't verify that constraint. Someth

[PATCH] mtd: rawnand: ingenic: Fix build error

2019-06-15 Thread YueHaibing
If MTD_NAND_JZ4780 is y and MTD_NAND_JZ4780_BCH is m, which select CONFIG_MTD_NAND_INGENIC_ECC to m, building fails: drivers/mtd/nand/raw/ingenic/ingenic_nand.o: In function `ingenic_nand_remove': ingenic_nand.c:(.text+0x177): undefined reference to `ingenic_ecc_release' drivers/mtd/nand/raw/ingen