Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe

2013-06-09 Thread Emil Goode
Hello, Sorry for not responding earlier, I was away from my computer. Thanks for the review, I will send a second version that applies on top of Andy's patch and fix that typo in the change log. Best regards, Emil On Mon, Jun 10, 2013 at 12:15:22AM +0300, Andy Shevchenko wrote: > On Sun, Jun 9,

Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe

2013-06-09 Thread Andy Shevchenko
On Sun, Jun 9, 2013 at 11:57 PM, Dan Carpenter wrote: > On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote: >> On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter >> wrote: >> > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote: >> >> What about another patch (that I guess

Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe

2013-06-09 Thread Dan Carpenter
On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote: > On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter > wrote: > > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote: > > [] > > >> What about another patch (that I guess should go first) that converts > >> printk to dev

Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe

2013-06-09 Thread Andy Shevchenko
On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter wrote: > On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote: [] >> What about another patch (that I guess should go first) that converts >> printk to dev_* or pr_*? > Huh, what? Those are two totally unrelated things. Emil's patch i

Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe

2013-06-09 Thread Dan Carpenter
On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote: > On Sun, Jun 9, 2013 at 12:08 PM, Emil Goode wrote: > > This patch fixes some issues in the error handling and simplifies > > the code by converting to devm* functions. > > > > If the kzalloc call fails it is unnecessary to use the

Re: [PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe

2013-06-09 Thread Andy Shevchenko
On Sun, Jun 9, 2013 at 12:08 PM, Emil Goode wrote: > This patch fixes some issues in the error handling and simplifies > the code by converting to devm* functions. > > If the kzalloc call fails it is unnecessary to use the label no_res > and pass a NULL pointer to kfree. If the devm_kzalloc call f

[PATCH] mtd: orion_nand: Improve error handling in orion_nand_probe

2013-06-09 Thread Emil Goode
This patch fixes some issues in the error handling and simplifies the code by converting to devm* functions. If the kzalloc call fails it is unnecessary to use the label no_res and pass a NULL pointer to kfree. If the devm_kzalloc call fails on line 110 we forgett to call iounmap for the previous