Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-18 Thread Robert Jarzmik
Brian Norris writes: > Hi Robert, > > On Mon, Aug 17, 2015 at 09:15:48PM +0200, Robert Jarzmik wrote: >> Ezequiel Garcia writes: >> > So unless I'm completely off, the current patch is right, and a comment >> > would be helpful. >> Ok Ezequiel, I'll wait for your Tested-by, and respin with somet

Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-18 Thread Brian Norris
Hi Robert, On Mon, Aug 17, 2015 at 09:15:48PM +0200, Robert Jarzmik wrote: > Ezequiel Garcia writes: > > So unless I'm completely off, the current patch is right, and a comment > > would be helpful. > Ok Ezequiel, I'll wait for your Tested-by, and respin with something like : > > /* Clear

Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-17 Thread Robert Jarzmik
Ezequiel Garcia writes: > In other words, it seems that we must wake the IRQ thread handler > _before_ we clear RDDREQ, not after. > > So unless I'm completely off, the current patch is right, and a comment > would be helpful. Ok Ezequiel, I'll wait for your Tested-by, and respin with something l

Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-17 Thread Ezequiel Garcia
On 16 August 2015 at 19:18, Robert Jarzmik wrote: > Ezequiel Garcia writes: > >> On 12 Aug 06:22 PM, Robert Jarzmik wrote: >> >> This fix looks correct. Thanks! >> >> Couple questions: >> >> 1. In which platform are you seeing this bug? > zylonite with a pxa310 (ie. internal stacked NAND). > >> 2

Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-16 Thread Robert Jarzmik
Ezequiel Garcia writes: > On 12 Aug 06:22 PM, Robert Jarzmik wrote: > > This fix looks correct. Thanks! > > Couple questions: > > 1. In which platform are you seeing this bug? zylonite with a pxa310 (ie. internal stacked NAND). > 2. Is this a regression? (i.e. should we queue it for -stable?) No

Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-16 Thread Ezequiel Garcia
On 12 Aug 06:22 PM, Robert Jarzmik wrote: > When 2 commands are submitted in a row, and the second is very quick, > the completion of the second command might never come. This happens > especially if the second command is quick, such as a status read after > an erase. > > The issue is that in the

[PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-12 Thread Robert Jarzmik
When 2 commands are submitted in a row, and the second is very quick, the completion of the second command might never come. This happens especially if the second command is quick, such as a status read after an erase. The issue is that in the interrupt handler, the status bits are cleared after t