Re: [PATCH] mpt3sas: Ensure the connector_name string is NUL-terminated

2016-08-08 Thread Martin K. Petersen
> "Calvin" == Calvin Owens writes: Calvin> We blindly trust the hardware to give us NUL-terminated strings, Calvin> which is a bad idea because it doesn't always do that. For Calvin> example: Calvin> [ 481.184784] mpt3sas_cm0: enclosure level(0x), connector Calvin> name( \x3) Calvin>

RE: [PATCH] mpt3sas: Ensure the connector_name string is NUL-terminated

2016-08-04 Thread Chaitra Basappa
-fusionlinux@broadcom.com; linux-s...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-t...@fb.com; Calvin Owens Subject: [PATCH] mpt3sas: Ensure the connector_name string is NUL-terminated We blindly trust the hardware to give us NUL-terminated strings, which is a bad idea because it

Re: [PATCH] mpt3sas: Ensure the connector_name string is NUL-terminated

2016-08-04 Thread Martin K. Petersen
> "Calvin" == Calvin Owens writes: Calvin> We blindly trust the hardware to give us NUL-terminated strings, Calvin> which is a bad idea because it doesn't always do that. For Calvin> example: Broadcom folks, please respond to this and other mpt3sas patches in the queue: https://patchwork.ke

[PATCH] mpt3sas: Ensure the connector_name string is NUL-terminated

2016-07-27 Thread Calvin Owens
We blindly trust the hardware to give us NUL-terminated strings, which is a bad idea because it doesn't always do that. For example: [ 481.184784] mpt3sas_cm0: enclosure level(0x), connector name( \x3) In this case, connector_name is four spaces. We got lucky here because the 2nd by