Re: [PATCH] move exit_task_work() before exit_fs().

2014-12-28 Thread Al Viro
On Mon, Dec 29, 2014 at 01:33:37AM +, Ma, Xindong wrote: > > On Fri, Dec 26, 2014 at 03:45:25PM +0800, Leon Ma wrote: > > > We encountered following panic. The scenario is the process is exiting > > > and executing its task work. When closing dev node, the driver > > > triggers a firmware reloa

RE: [PATCH] move exit_task_work() before exit_fs().

2014-12-28 Thread Ma, Xindong
> On 12/28/2014 07:58 PM, Ma, Xindong wrote: > >> > >> On 12/26, Leon Ma wrote: > >>> > >>> We encountered following panic. The scenario is the process is > >>> exiting and executing its task work. When closing dev node, the > >>> driver triggers a firmware reload according to device status. > >>>

RE: [PATCH] move exit_task_work() before exit_fs().

2014-12-28 Thread Ma, Xindong
> On Fri, Dec 26, 2014 at 03:45:25PM +0800, Leon Ma wrote: > > We encountered following panic. The scenario is the process is exiting > > and executing its task work. When closing dev node, the driver > > triggers a firmware reload according to device status. Because task->fs is > set to NULL in ex

Re: [PATCH] move exit_task_work() before exit_fs().

2014-12-28 Thread Peter Hurley
On 12/28/2014 07:58 PM, Ma, Xindong wrote: >> >> On 12/26, Leon Ma wrote: >>> >>> We encountered following panic. The scenario is the process is exiting >>> and executing its task work. When closing dev node, the driver >>> triggers a firmware reload according to device status. Because task->fs is

RE: [PATCH] move exit_task_work() before exit_fs().

2014-12-28 Thread Ma, Xindong
> > On 12/26, Leon Ma wrote: > > > > We encountered following panic. The scenario is the process is exiting > > and executing its task work. When closing dev node, the driver > > triggers a firmware reload according to device status. Because task->fs is > set to NULL in exit_fs(), panic happens. >

Re: [PATCH] move exit_task_work() before exit_fs().

2014-12-26 Thread Al Viro
On Fri, Dec 26, 2014 at 03:45:25PM +0800, Leon Ma wrote: > We encountered following panic. The scenario is the process is exiting and > executing its > task work. When closing dev node, the driver triggers a firmware reload > according to device > status. Because task->fs is set to NULL in exit_f

Re: [PATCH] move exit_task_work() before exit_fs().

2014-12-26 Thread Oleg Nesterov
On 12/26, Leon Ma wrote: > > We encountered following panic. The scenario is the process is exiting and > executing its > task work. When closing dev node, the driver triggers a firmware reload > according to device > status. Because task->fs is set to NULL in exit_fs(), panic happens. I think t

[PATCH] move exit_task_work() before exit_fs().

2014-12-25 Thread Leon Ma
We encountered following panic. The scenario is the process is exiting and executing its task work. When closing dev node, the driver triggers a firmware reload according to device status. Because task->fs is set to NULL in exit_fs(), panic happens. Task work is a common interface, we should not