Re: [PATCH] module.c: add missing ifdefs for CONFIG_UNUSED_SYMBOLS

2007-09-13 Thread Denys Vlasenko
On Friday 14 September 2007 00:00, Andrew Morton wrote: > > In short, patch makes trivial changes which are "obviously correct" > > (famous last words). > > The intent seems reasonable. Would have preferred separate patches for the > separate things though.. > > This: > > akpm:/usr/src/25> grep

Re: [PATCH] module.c: add missing ifdefs for CONFIG_UNUSED_SYMBOLS

2007-09-13 Thread Andrew Morton
On Thu, 13 Sep 2007 23:30:33 +0100 Denys Vlasenko <[EMAIL PROTECTED]> wrote: > module.c and module.h conatains code for finding > exported symbols which are declared with EXPORT_UNUSED_SYMBOL, > and this code is compiled in even if CONFIG_UNUSED_SYMBOLS is not set > and thus there can be no EXPORT

[PATCH] module.c: add missing ifdefs for CONFIG_UNUSED_SYMBOLS

2007-09-13 Thread Denys Vlasenko
Hi Andrew, module.c and module.h conatains code for finding exported symbols which are declared with EXPORT_UNUSED_SYMBOL, and this code is compiled in even if CONFIG_UNUSED_SYMBOLS is not set and thus there can be no EXPORT_UNUSED_SYMBOLs in modules anyway (because EXPORT_UNUSED_SYMBOL(x) are com