Re: [PATCH] module: Taint the kernel when write-protecting ro_after_init fails

2025-03-20 Thread Daniel Gomez
On Thu, Mar 06, 2025 at 11:36:55AM +0100, Petr Pavlu wrote: > In the unlikely case that setting ro_after_init data to read-only fails, it > is too late to cancel loading of the module. The loader then issues only > a warning about the situation. Given that this reduces the kernel's > protection, it

Re: [PATCH] module: Taint the kernel when write-protecting ro_after_init fails

2025-03-14 Thread Kees Cook
On Fri, Mar 14, 2025 at 05:48:00PM +0100, Christophe Leroy wrote: > > > Le 12/03/2025 à 17:30, Kees Cook a écrit : > > On Wed, Mar 12, 2025 at 04:45:24PM +0100, Vlastimil Babka wrote: > > > On 3/6/25 17:57, Luis Chamberlain wrote: > > > > + linux-mm since we're adding TAINT_BAD_PAGE > > > > > >

Re: [PATCH] module: Taint the kernel when write-protecting ro_after_init fails

2025-03-14 Thread Christophe Leroy
Le 12/03/2025 à 17:30, Kees Cook a écrit : On Wed, Mar 12, 2025 at 04:45:24PM +0100, Vlastimil Babka wrote: On 3/6/25 17:57, Luis Chamberlain wrote: + linux-mm since we're adding TAINT_BAD_PAGE On Thu, Mar 06, 2025 at 11:36:55AM +0100, Petr Pavlu wrote: In the unlikely case that setting ro

Re: [PATCH] module: Taint the kernel when write-protecting ro_after_init fails

2025-03-12 Thread Luis Chamberlain
On Wed, Mar 12, 2025 at 09:30:28AM -0700, Kees Cook wrote: > On Wed, Mar 12, 2025 at 04:45:24PM +0100, Vlastimil Babka wrote: > > On 3/6/25 17:57, Luis Chamberlain wrote: > > > + linux-mm since we're adding TAINT_BAD_PAGE > > > > > > On Thu, Mar 06, 2025 at 11:36:55AM +0100, Petr Pavlu wrote: > >

Re: [PATCH] module: Taint the kernel when write-protecting ro_after_init fails

2025-03-12 Thread Kees Cook
On Wed, Mar 12, 2025 at 04:45:24PM +0100, Vlastimil Babka wrote: > On 3/6/25 17:57, Luis Chamberlain wrote: > > + linux-mm since we're adding TAINT_BAD_PAGE > > > > On Thu, Mar 06, 2025 at 11:36:55AM +0100, Petr Pavlu wrote: > >> In the unlikely case that setting ro_after_init data to read-only fa

Re: [PATCH] module: Taint the kernel when write-protecting ro_after_init fails

2025-03-12 Thread Vlastimil Babka
On 3/6/25 17:57, Luis Chamberlain wrote: > + linux-mm since we're adding TAINT_BAD_PAGE > > On Thu, Mar 06, 2025 at 11:36:55AM +0100, Petr Pavlu wrote: >> In the unlikely case that setting ro_after_init data to read-only fails, it >> is too late to cancel loading of the module. The loader then iss

Re: [PATCH] module: Taint the kernel when write-protecting ro_after_init fails

2025-03-07 Thread Luis Chamberlain
+ linux-mm since we're adding TAINT_BAD_PAGE On Thu, Mar 06, 2025 at 11:36:55AM +0100, Petr Pavlu wrote: > In the unlikely case that setting ro_after_init data to read-only fails, it > is too late to cancel loading of the module. The loader then issues only > a warning about the situation. Given t

Re: [PATCH] module: Taint the kernel when write-protecting ro_after_init fails

2025-03-06 Thread Petr Pavlu
+To: Christophe Leroy On 3/6/25 11:36, Petr Pavlu wrote: > In the unlikely case that setting ro_after_init data to read-only fails, it > is too late to cancel loading of the module. The loader then issues only > a warning about the situation. Given that this reduces the kernel's > protection, it

[PATCH] module: Taint the kernel when write-protecting ro_after_init fails

2025-03-06 Thread Petr Pavlu
In the unlikely case that setting ro_after_init data to read-only fails, it is too late to cancel loading of the module. The loader then issues only a warning about the situation. Given that this reduces the kernel's protection, it was suggested to make the failure more visible by tainting the kern