Re: [PATCH] mmc: sdhci-pxav3: Fix Sparse warning of duplicate set_uhs_signaling entry

2014-10-28 Thread Sebastian Hesselbarth
On 10/28/2014 05:41 PM, Pramod Gurav wrote: Hi Ulf, Is this good to go? Uhm, no it isn't. pxav3 needs a special set_uhs_signaling handler, remove the standard sdhci provided instead. Sebastian On Mon, Sep 29, 2014 at 6:55 PM, Pramod Gurav wrote: This fixes below sparse warning: drivers/mm

Re: [PATCH] mmc: sdhci-pxav3: Fix Sparse warning of duplicate set_uhs_signaling entry

2014-10-28 Thread Pramod Gurav
Hi Ulf, Is this good to go? On Mon, Sep 29, 2014 at 6:55 PM, Pramod Gurav wrote: > This fixes below sparse warning: > drivers/mmc/host/sdhci-pxav3.c:227:10: warning: Initializer entry defined > twice > drivers/mmc/host/sdhci-pxav3.c:232:10: also defined here > > by removing duplicate initiali

[PATCH] mmc: sdhci-pxav3: Fix Sparse warning of duplicate set_uhs_signaling entry

2014-09-29 Thread Pramod Gurav
This fixes below sparse warning: drivers/mmc/host/sdhci-pxav3.c:227:10: warning: Initializer entry defined twice drivers/mmc/host/sdhci-pxav3.c:232:10: also defined here by removing duplicate initialization of .set_uhs_signaling in struct sdhci_ops. Also does away with duplcated function. Cc: R