Re: [PATCH] mmc: sdhci-of-arasan: refactor set_clock callback

2016-04-28 Thread Shawn Lin
On 2016/4/28 16:00, Adrian Hunter wrote: "refactor" typically means no change in behaviour. This looks like a fix e.g. "Fix set_clock when a phy is supported" Thanks, will fix it. On 27/04/16 07:14, Shawn Lin wrote: commit 61b914eb81f8 ("mmc: sdhci-of-arasan: add phy support for sdhci-of-a

Re: [PATCH] mmc: sdhci-of-arasan: refactor set_clock callback

2016-04-28 Thread Adrian Hunter
"refactor" typically means no change in behaviour. This looks like a fix e.g. "Fix set_clock when a phy is supported" On 27/04/16 07:14, Shawn Lin wrote: > commit 61b914eb81f8 ("mmc: sdhci-of-arasan: add phy support for > sdhci-of-arasan") introduce phy support for arasan. According to > the vend

[PATCH] mmc: sdhci-of-arasan: refactor set_clock callback

2016-04-26 Thread Shawn Lin
commit 61b914eb81f8 ("mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan") introduce phy support for arasan. According to the vendor's databook, we should make sure the phy is in poweroff status before we configure the clk stuff. Otherwise it may cause some IO sample timing issues from the t