Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-18 Thread Tim Kryger
On Wed, Apr 16, 2014 at 12:20 AM, Ulf Hansson wrote: > On 15 April 2014 19:09, Tim Kryger wrote: >> On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote: >>> A few times I have suggested to switch to use the >>> mmc_regulator_get_supply() API to simplify and consolidate code. Could >>> you please

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-16 Thread Ulf Hansson
On 15 April 2014 19:09, Tim Kryger wrote: > On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote: > >> I have seen some patches around lately touching the code for handling >> the regulators (vcc and vccq) in sdhci. > > Was it this patch you were thinking of or something else? > > http://www.spinic

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-15 Thread Tim Kryger
On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote: > I have seen some patches around lately touching the code for handling > the regulators (vcc and vccq) in sdhci. Was it this patch you were thinking of or something else? http://www.spinics.net/lists/linux-mmc/msg25640.html > A few times I h

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-11 Thread Tim Kryger
On Fri, Apr 11, 2014 at 1:15 AM, Ulf Hansson wrote: > On 11 April 2014 01:31, Tim Kryger wrote: >> +static unsigned int sdhci_get_ocr_avail_from_vmmc(struct sdhci_host *host) >> +{ >> + unsigned int ocr_avail = 0; >> + struct regulator *vmmc = host->vmmc; >> + >> + if (regulato

Re: [PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-11 Thread Ulf Hansson
On 11 April 2014 01:31, Tim Kryger wrote: > When an external regulator provides VDD, set ocr_avail directly based on > the supported voltage range. This allows for the use of regulators that > can't provide exactly 1.8v, 3.0v, or 3.3v and ensures that ocr_avil bits > are only set for supported vo

[PATCH] mmc: sdhci: Set ocr_avail directly based on vmmc

2014-04-10 Thread Tim Kryger
When an external regulator provides VDD, set ocr_avail directly based on the supported voltage range. This allows for the use of regulators that can't provide exactly 1.8v, 3.0v, or 3.3v and ensures that ocr_avil bits are only set for supported voltage ranges. Commit cec2e21 had attempted to rela