Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

Hi, On Thu, Jul 12 2012, S, Venkatraman wrote: > On Wed, Jul 11, 2012 at 5:10 AM, Kevin Hilman wrote: >> If platform_get_resource_by_name() fails, driver probe is aborted an >> should return an error so the driver is not bound to the device. >> >> However, in the current error path of platform_ge

Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

On Wed, Jul 11, 2012 at 5:10 AM, Kevin Hilman wrote: > If platform_get_resource_by_name() fails, driver probe is aborted an > should return an error so the driver is not bound to the device. > > However, in the current error path of platform_get_resource_by_name(), > probe returns zero since the r

[PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

If platform_get_resource_by_name() fails, driver probe is aborted an should return an error so the driver is not bound to the device. However, in the current error path of platform_get_resource_by_name(), probe returns zero since the return value (ret) is not properly set. With a zero return value