Re: [PATCH] mm: vmscan: count only dirty pages as congested

2014-10-15 Thread Andrew Morton
On Wed, 15 Oct 2014 16:07:42 -0700 Jamie Liu wrote: > On Wed, Oct 15, 2014 at 1:05 PM, Andrew Morton > wrote: > > On Wed, 15 Oct 2014 12:58:35 -0700 Jamie Liu wrote: > > > >> shrink_page_list() counts all pages with a mapping, including clean > >> pages, toward nr_congested if they're on a writ

Re: [PATCH] mm: vmscan: count only dirty pages as congested

2014-10-15 Thread Jamie Liu
wait_iff_congested() only waits if ZONE_CONGESTED is set (and at least one BDI is still congested). Modulo concurrent changes to BDI congestion status: After this change, the probability that a given shrink_inactive_list() sets ZONE_CONGESTED increases monotonically with the fraction of dirty page

[PATCH] mm: vmscan: count only dirty pages as congested

2014-10-15 Thread Jamie Liu
shrink_page_list() counts all pages with a mapping, including clean pages, toward nr_congested if they're on a write-congested BDI. shrink_inactive_list() then sets ZONE_CONGESTED if nr_dirty == nr_congested. Fix this apples-to-oranges comparison by only counting pages for nr_congested if they coun

Re: [PATCH] mm: vmscan: count only dirty pages as congested

2014-10-15 Thread Andrew Morton
On Wed, 15 Oct 2014 12:58:35 -0700 Jamie Liu wrote: > shrink_page_list() counts all pages with a mapping, including clean > pages, toward nr_congested if they're on a write-congested BDI. > shrink_inactive_list() then sets ZONE_CONGESTED if nr_dirty == > nr_congested. Fix this apples-to-oranges c