Re: [PATCH] mm: slub: re-initialize randomized freelist sequence in calculate_sizes

2020-08-19 Thread Thomas Garnier
I am not super familiar with the sysfs setup here but the random sequence should work as expected. One minor comment below. Reviewed-by: Thomas Garnier On Wed, Aug 19, 2020 at 1:26 PM Andrew Morton wrote: > > > (cc Thomas and linux-mm) > > On Sat, 8 Aug 2020 13:50:30 +0400 kpark3...@gmail.com

Re: [PATCH] mm: slub: re-initialize randomized freelist sequence in calculate_sizes

2020-08-19 Thread Kees Cook
On Sat, Aug 08, 2020 at 01:50:30PM +0400, kpark3...@gmail.com wrote: > From: Sahara Hi! > > Slab cache flags are exported to sysfs and are allowed to get modified > from userspace. Some of those may call calculate_sizes function because > the changed flag can take an effect on slab object size

Re: [PATCH] mm: slub: re-initialize randomized freelist sequence in calculate_sizes

2020-08-19 Thread Andrew Morton
(cc Thomas and linux-mm) On Sat, 8 Aug 2020 13:50:30 +0400 kpark3...@gmail.com wrote: > From: Sahara > > Slab cache flags are exported to sysfs and are allowed to get modified > from userspace. Some of those may call calculate_sizes function because > the changed flag can take an effect on s

[PATCH] mm: slub: re-initialize randomized freelist sequence in calculate_sizes

2020-08-08 Thread kpark3469
From: Sahara Slab cache flags are exported to sysfs and are allowed to get modified from userspace. Some of those may call calculate_sizes function because the changed flag can take an effect on slab object size and layout, which means kmem_cache may have different order and objects. The freelist