Re: [External] Re: [PATCH] mm: memcontrol: fix missing wakeup oom task

2021-02-05 Thread Muchun Song
On Fri, Feb 5, 2021 at 4:24 PM Michal Hocko wrote: > > On Fri 05-02-21 14:23:10, Muchun Song wrote: > > We call memcg_oom_recover() in the uncharge_batch() to wakeup OOM task > > when page uncharged, but for the slab pages, we do not do this when page > > uncharged. > > How does the patch deal wit

Re: [External] Re: [PATCH] mm: memcontrol: fix missing wakeup oom task

2021-02-05 Thread Michal Hocko
On Fri 05-02-21 19:04:19, Muchun Song wrote: > On Fri, Feb 5, 2021 at 6:21 PM Michal Hocko wrote: > > > > On Fri 05-02-21 17:55:10, Muchun Song wrote: > > > On Fri, Feb 5, 2021 at 4:24 PM Michal Hocko wrote: > > > > > > > > On Fri 05-02-21 14:23:10, Muchun Song wrote: > > > > > We call memcg_oom_

Re: [External] Re: [PATCH] mm: memcontrol: fix missing wakeup oom task

2021-02-05 Thread Muchun Song
On Fri, Feb 5, 2021 at 8:20 PM Michal Hocko wrote: > > On Fri 05-02-21 19:04:19, Muchun Song wrote: > > On Fri, Feb 5, 2021 at 6:21 PM Michal Hocko wrote: > > > > > > On Fri 05-02-21 17:55:10, Muchun Song wrote: > > > > On Fri, Feb 5, 2021 at 4:24 PM Michal Hocko wrote: > > > > > > > > > > On Fr

Re: [External] Re: [PATCH] mm: memcontrol: fix missing wakeup oom task

2021-02-05 Thread Michal Hocko
On Fri 05-02-21 23:30:36, Muchun Song wrote: > On Fri, Feb 5, 2021 at 8:20 PM Michal Hocko wrote: > > > > On Fri 05-02-21 19:04:19, Muchun Song wrote: > > > On Fri, Feb 5, 2021 at 6:21 PM Michal Hocko wrote: > > > > > > > > On Fri 05-02-21 17:55:10, Muchun Song wrote: > > > > > On Fri, Feb 5, 202

Re: [External] Re: [PATCH] mm: memcontrol: fix missing wakeup oom task

2021-02-05 Thread Muchun Song
On Fri, Feb 5, 2021 at 6:21 PM Michal Hocko wrote: > > On Fri 05-02-21 17:55:10, Muchun Song wrote: > > On Fri, Feb 5, 2021 at 4:24 PM Michal Hocko wrote: > > > > > > On Fri 05-02-21 14:23:10, Muchun Song wrote: > > > > We call memcg_oom_recover() in the uncharge_batch() to wakeup OOM task > > >

Re: [External] Re: [PATCH] mm: memcontrol: fix missing wakeup oom task

2021-02-05 Thread Michal Hocko
On Fri 05-02-21 17:55:10, Muchun Song wrote: > On Fri, Feb 5, 2021 at 4:24 PM Michal Hocko wrote: > > > > On Fri 05-02-21 14:23:10, Muchun Song wrote: > > > We call memcg_oom_recover() in the uncharge_batch() to wakeup OOM task > > > when page uncharged, but for the slab pages, we do not do this w

Re: [PATCH] mm: memcontrol: fix missing wakeup oom task

2021-02-05 Thread Michal Hocko
On Fri 05-02-21 14:23:10, Muchun Song wrote: > We call memcg_oom_recover() in the uncharge_batch() to wakeup OOM task > when page uncharged, but for the slab pages, we do not do this when page > uncharged. How does the patch deal with this? > When we drain per cpu stock, we also should do this.

[PATCH] mm: memcontrol: fix missing wakeup oom task

2021-02-04 Thread Muchun Song
We call memcg_oom_recover() in the uncharge_batch() to wakeup OOM task when page uncharged, but for the slab pages, we do not do this when page uncharged. When we drain per cpu stock, we also should do this. The memcg_oom_recover() is small, so make it inline. And the parameter of memcg cannot be