Re: [PATCH] mm: memcontrol: clarify the uncharge_list() loop

2016-03-11 Thread Michal Hocko
On Thu 10-03-16 15:50:15, Johannes Weiner wrote: > uncharge_list() does an unusual list walk because the function can > take regular lists with dedicated list_heads as well as singleton > lists where a single page is passed via the page->lru list node. > > This can sometimes lead to confusion as w

Re: [PATCH] mm: memcontrol: clarify the uncharge_list() loop

2016-03-10 Thread Johannes Weiner
On Thu, Mar 10, 2016 at 01:30:34PM -0800, Andrew Morton wrote: > > LGTM. It's very late in the cycle so I'll queue all three for 4.6-rc1 > and I tagged the first two patches (not this one) for -stable > backporting. Sounds good, thank you.

Re: [PATCH] mm: memcontrol: clarify the uncharge_list() loop

2016-03-10 Thread Andrew Morton
LGTM. It's very late in the cycle so I'll queue all three for 4.6-rc1 and I tagged the first two patches (not this one) for -stable backporting.

[PATCH] mm: memcontrol: clarify the uncharge_list() loop

2016-03-10 Thread Johannes Weiner
uncharge_list() does an unusual list walk because the function can take regular lists with dedicated list_heads as well as singleton lists where a single page is passed via the page->lru list node. This can sometimes lead to confusion as well as suggestions to replace the loop with a list_for_each