Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat

2020-10-26 Thread Song Liu
> On Oct 22, 2020, at 8:18 AM, Johannes Weiner wrote: > > As huge page usage in the page cache and for shmem files proliferates > in our production environment, the performance monitoring team has > asked for per-cgroup stats on those pages. > > We already track and export anon_thp per cgroup

Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat

2020-10-26 Thread Johannes Weiner
owerpc). > > */ > > { "anon_thp", 0, NR_ANON_THPS }, > > + { "file_thp", 0, NR_FILE_THPS }, > > + { "shmem_thp", 0, NR_SHMEM_THPS }, > > Documentation/admin-guide/cgroup-v2.rst is owed an update? Ah yes. This? >From 310c3e1714

Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat

2020-10-25 Thread Andrew Morton
On Thu, 22 Oct 2020 11:18:44 -0400 Johannes Weiner wrote: > As huge page usage in the page cache and for shmem files proliferates > in our production environment, the performance monitoring team has > asked for per-cgroup stats on those pages. > > We already track and export anon_thp per cgroup.

Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat

2020-10-23 Thread Michal Hocko
On Thu 22-10-20 11:18:44, Johannes Weiner wrote: > As huge page usage in the page cache and for shmem files proliferates > in our production environment, the performance monitoring team has > asked for per-cgroup stats on those pages. > > We already track and export anon_thp per cgroup. We already

Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat

2020-10-22 Thread Johannes Weiner
On Thu, Oct 22, 2020 at 12:57:55PM -0400, Rik van Riel wrote: > On Thu, 2020-10-22 at 12:49 -0400, Rik van Riel wrote: > > On Thu, 2020-10-22 at 11:18 -0400, Johannes Weiner wrote: > > > > > index e80aa9d2db68..334ce608735c 100644 > > > --- a/mm/filemap.c > > > +++ b/mm/filemap.c > > > @@ -204,9 +

Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat

2020-10-22 Thread David Rientjes
On Thu, 22 Oct 2020, Johannes Weiner wrote: > As huge page usage in the page cache and for shmem files proliferates > in our production environment, the performance monitoring team has > asked for per-cgroup stats on those pages. > > We already track and export anon_thp per cgroup. We already tra

Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat

2020-10-22 Thread Rik van Riel
On Thu, 2020-10-22 at 12:49 -0400, Rik van Riel wrote: > On Thu, 2020-10-22 at 11:18 -0400, Johannes Weiner wrote: > > > index e80aa9d2db68..334ce608735c 100644 > > --- a/mm/filemap.c > > +++ b/mm/filemap.c > > @@ -204,9 +204,9 @@ static void unaccount_page_cache_page(struct > > address_space *map

Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat

2020-10-22 Thread Shakeel Butt
On Thu, Oct 22, 2020 at 8:20 AM Johannes Weiner wrote: > > As huge page usage in the page cache and for shmem files proliferates > in our production environment, the performance monitoring team has > asked for per-cgroup stats on those pages. > > We already track and export anon_thp per cgroup. We

Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat

2020-10-22 Thread Rik van Riel
On Thu, 2020-10-22 at 11:18 -0400, Johannes Weiner wrote: > index e80aa9d2db68..334ce608735c 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -204,9 +204,9 @@ static void unaccount_page_cache_page(struct > address_space *mapping, > if (PageSwapBacked(page)) { > __mod_lruve

[PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat

2020-10-22 Thread Johannes Weiner
As huge page usage in the page cache and for shmem files proliferates in our production environment, the performance monitoring team has asked for per-cgroup stats on those pages. We already track and export anon_thp per cgroup. We already track file THP and shmem THP per node, so making them per-