Re: [PATCH] mm: make allocation counters per-order

2017-07-16 Thread Roman Gushchin
On Thu, Jul 06, 2017 at 04:47:05PM +0100, Mel Gorman wrote: > On Thu, Jul 06, 2017 at 03:46:34PM +0100, Roman Gushchin wrote: > > > The alloc counter updates are themselves a surprisingly heavy cost to > > > the allocation path and this makes it worse for a debugging case that is > > > relatively r

Re: [PATCH] mm: make allocation counters per-order

2017-07-16 Thread Roman Gushchin
>From 36c6f4d293469569ca8b53b89ab8eebd358a5fa5 Mon Sep 17 00:00:00 2001 From: Roman Gushchin Date: Mon, 3 Jul 2017 19:02:49 +0100 Subject: [v2] mm: make allocation counters per-order High-order allocations are obviously more costly, and it's very useful to know how many of them happens, if there

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread kbuild test robot
Hi Roman, [auto build test WARNING on mmotm/master] [also build test WARNING on next-20170706] [cannot apply to v4.12] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-make-alloc

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread kbuild test robot
Hi Roman, [auto build test ERROR on mmotm/master] [also build test ERROR on next-20170706] [cannot apply to v4.12] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-make-allocatio

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Mel Gorman
On Thu, Jul 06, 2017 at 02:00:00PM -0400, Debabrata Banerjee wrote: > On Thu, Jul 6, 2017 at 1:16 PM, Mel Gorman > wrote: > > > > I'm still struggling to see how counters help when an agent that monitors > > for high CPU usage could be activated > > > > I suspect Roman has the same problem set a

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Debabrata Banerjee
On Thu, Jul 6, 2017 at 1:16 PM, Mel Gorman wrote: > > I'm still struggling to see how counters help when an agent that monitors > for high CPU usage could be activated > I suspect Roman has the same problem set as us, the CPU usage is either always high, high and service critical likely when some

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Mel Gorman
On Thu, Jul 06, 2017 at 05:43:04PM +0100, Roman Gushchin wrote: > > At the time I used a page allocator microbenchmark from mmtests to call > > the allocator directly without zeroing pages. Triggering allocations from > > userspace generally mask the overhead by the zeroing costs. It's just a few >

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Roman Gushchin
On Thu, Jul 06, 2017 at 04:47:05PM +0100, Mel Gorman wrote: > On Thu, Jul 06, 2017 at 03:46:34PM +0100, Roman Gushchin wrote: > > > The alloc counter updates are themselves a surprisingly heavy cost to > > > the allocation path and this makes it worse for a debugging case that is > > > relatively r

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Mel Gorman
On Thu, Jul 06, 2017 at 12:12:47PM -0400, Debabrata Banerjee wrote: > On Thu, Jul 6, 2017 at 11:51 AM, Mel Gorman > wrote: > > > > These counters do not actually help you solve that particular problem. > > Knowing how many allocations happened since the system booted doesn't tell > > you much abo

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Debabrata Banerjee
On Thu, Jul 6, 2017 at 11:51 AM, Mel Gorman wrote: > > These counters do not actually help you solve that particular problem. > Knowing how many allocations happened since the system booted doesn't tell > you much about how many failed or why they failed. You don't even know > what frequency they

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Mel Gorman
On Thu, Jul 06, 2017 at 10:54:24AM -0400, Debabrata Banerjee wrote: > On Thu, Jul 6, 2017 at 9:19 AM, Mel Gorman > wrote: > > > The alloc counter updates are themselves a surprisingly heavy cost to > > the allocation path and this makes it worse for a debugging case that is > > relatively rare.

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Mel Gorman
On Thu, Jul 06, 2017 at 03:46:34PM +0100, Roman Gushchin wrote: > > The alloc counter updates are themselves a surprisingly heavy cost to > > the allocation path and this makes it worse for a debugging case that is > > relatively rare. I'm extremely reluctant for such a patch to be added > > given

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Christoph Lameter
On Thu, 6 Jul 2017, Roman Gushchin wrote: > +#define PGALLOC_EVENTS_SIZE (MAX_NR_ZONES * MAX_ORDER) > +#define PGALLOC_EVENTS_CUT_SIZE (MAX_NR_ZONES * (MAX_ORDER - 1)) > +#define PGALLOC_FIRST_ZONE (PGALLOC_NORMAL - ZONE_NORMAL) You are significantly increasing the per cpu counters (ZONES * MAX_

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Debabrata Banerjee
On Thu, Jul 6, 2017 at 9:19 AM, Mel Gorman wrote: > The alloc counter updates are themselves a surprisingly heavy cost to > the allocation path and this makes it worse for a debugging case that is > relatively rare. I'm extremely reluctant for such a patch to be added > given that the tracepoints

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Roman Gushchin
On Thu, Jul 06, 2017 at 02:19:41PM +0100, Mel Gorman wrote: > On Thu, Jul 06, 2017 at 02:04:31PM +0100, Roman Gushchin wrote: > > High-order allocations are obviously more costly, and it's very useful > > to know how many of them happens, if there are any issues > > (or suspicions) with memory frag

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Mel Gorman
On Thu, Jul 06, 2017 at 02:04:31PM +0100, Roman Gushchin wrote: > High-order allocations are obviously more costly, and it's very useful > to know how many of them happens, if there are any issues > (or suspicions) with memory fragmentation. > > This commit changes existing per-zone allocation cou

[PATCH] mm: make allocation counters per-order

2017-07-06 Thread Roman Gushchin
High-order allocations are obviously more costly, and it's very useful to know how many of them happens, if there are any issues (or suspicions) with memory fragmentation. This commit changes existing per-zone allocation counters to be per-zone per-order. These counters are displayed using a new p