Re: [PATCH] mm: kvmalloc does not fallback to vmalloc for incompatible gfp flags

2018-06-03 Thread Michal Hocko
On Sat 02-06-18 09:43:56, Linus Torvalds wrote: > On Fri, Jun 1, 2018 at 4:53 AM Michal Hocko wrote: > > > > for more context. Linus has pointed out [1] that our (well mine) > > insisting on GFP_KERNEL compatible gfp flags for kvmalloc* can actually > > lead to a worse code because people will wor

Re: [PATCH] mm: kvmalloc does not fallback to vmalloc for incompatible gfp flags

2018-06-02 Thread Linus Torvalds
On Fri, Jun 1, 2018 at 4:53 AM Michal Hocko wrote: > > for more context. Linus has pointed out [1] that our (well mine) > insisting on GFP_KERNEL compatible gfp flags for kvmalloc* can actually > lead to a worse code because people will work around the restriction. > So this patch allows kvmalloc

[PATCH] mm: kvmalloc does not fallback to vmalloc for incompatible gfp flags

2018-06-01 Thread Michal Hocko
From: Michal Hocko kvmalloc warned about incompatible gfp_mask to catch abusers (mostly GFP_NOFS) with an intention that this will motivate authors of the code to fix those. Linus argues that this just motivates people to do even more hacks like if (gfp == GFP_KERNEL) kvma