Re: [PATCH] mm: get rid of __alloc_pages_high_priority

2015-11-13 Thread David Rientjes
On Fri, 13 Nov 2015, Michal Hocko wrote: > > > Hi, > > > I think that this is more a cleanup than any functional change. We > > > are rarely screwed so much that __alloc_pages_high_priority would > > > fail. Yet I think that __alloc_pages_high_priority is obscuring the > > > overal intention more

Re: [PATCH] mm: get rid of __alloc_pages_high_priority

2015-11-13 Thread Mel Gorman
On Thu, Nov 12, 2015 at 04:53:38PM +0100, mho...@kernel.org wrote: > From: Michal Hocko > > __alloc_pages_high_priority doesn't do anything special other than it > calls get_page_from_freelist and loops around GFP_NOFAIL allocation > until it succeeds. It would be better if the first part was don

Re: [PATCH] mm: get rid of __alloc_pages_high_priority

2015-11-13 Thread Michal Hocko
On Thu 12-11-15 12:47:45, David Rientjes wrote: > On Thu, 12 Nov 2015, mho...@kernel.org wrote: [...] > > Hi, > > I think that this is more a cleanup than any functional change. We > > are rarely screwed so much that __alloc_pages_high_priority would > > fail. Yet I think that __alloc_pages_high_pr

Re: [PATCH] mm: get rid of __alloc_pages_high_priority

2015-11-12 Thread David Rientjes
On Thu, 12 Nov 2015, mho...@kernel.org wrote: > From: Michal Hocko > > __alloc_pages_high_priority doesn't do anything special other than it > calls get_page_from_freelist and loops around GFP_NOFAIL allocation > until it succeeds. It would be better if the first part was done in > __alloc_pages

[PATCH] mm: get rid of __alloc_pages_high_priority

2015-11-12 Thread mhocko
From: Michal Hocko __alloc_pages_high_priority doesn't do anything special other than it calls get_page_from_freelist and loops around GFP_NOFAIL allocation until it succeeds. It would be better if the first part was done in __alloc_pages_slowpath where we modify the zonelist because this would b