Re: [PATCH] mm: fix insert_pfn() return value

2018-11-27 Thread Måns Rullgård
Matthew Wilcox writes: > On Tue, Nov 27, 2018 at 02:43:51PM +, Mans Rullgard wrote: >> Commit 9b5a8e00d479 ("mm: convert insert_pfn() to vm_fault_t") accidentally >> made insert_pfn() always return an error. Fix this. > > Umm. VM_FAULT_NOPAGE is not an error. It's saying "I inserted the PF

Re: [PATCH] mm: fix insert_pfn() return value

2018-11-27 Thread Matthew Wilcox
On Tue, Nov 27, 2018 at 02:43:51PM +, Mans Rullgard wrote: > Commit 9b5a8e00d479 ("mm: convert insert_pfn() to vm_fault_t") accidentally > made insert_pfn() always return an error. Fix this. Umm. VM_FAULT_NOPAGE is not an error. It's saying "I inserted the PFN, there's no struct page for th

[PATCH] mm: fix insert_pfn() return value

2018-11-27 Thread Mans Rullgard
Commit 9b5a8e00d479 ("mm: convert insert_pfn() to vm_fault_t") accidentally made insert_pfn() always return an error. Fix this. Fixes: 9b5a8e00d479 ("mm: convert insert_pfn() to vm_fault_t") Signed-off-by: Mans Rullgard --- mm/memory.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)