Re: [PATCH] mm: export cma alloc and release

2019-10-07 Thread Mark Salyzyn
On 10/7/19 9:53 AM, Christoph Hellwig wrote: On Mon, Oct 07, 2019 at 09:50:31AM -0700, Mark Salyzyn wrote: On 10/5/19 1:37 AM, Christoph Hellwig wrote: On Thu, Oct 03, 2019 at 09:55:28AM +0100, Catalin Marinas wrote: Aren't drivers supposed to use the DMA API for such allocations rather than i

Re: [PATCH] mm: export cma alloc and release

2019-10-07 Thread Christoph Hellwig
On Mon, Oct 07, 2019 at 09:50:31AM -0700, Mark Salyzyn wrote: > On 10/5/19 1:37 AM, Christoph Hellwig wrote: >> On Thu, Oct 03, 2019 at 09:55:28AM +0100, Catalin Marinas wrote: >>> Aren't drivers supposed to use the DMA API for such allocations rather >>> than invoking cma_*() directly? >> Yes, the

Re: [PATCH] mm: export cma alloc and release

2019-10-07 Thread Mark Salyzyn
On 10/5/19 1:37 AM, Christoph Hellwig wrote: On Thu, Oct 03, 2019 at 09:55:28AM +0100, Catalin Marinas wrote: Aren't drivers supposed to use the DMA API for such allocations rather than invoking cma_*() directly? Yes, they are. We have an engineer assigned to rewriting the ion memory driver t

Re: [PATCH] mm: export cma alloc and release

2019-10-05 Thread Christoph Hellwig
On Thu, Oct 03, 2019 at 09:55:28AM +0100, Catalin Marinas wrote: > Aren't drivers supposed to use the DMA API for such allocations rather > than invoking cma_*() directly? Yes, they are.

Re: [PATCH] mm: export cma alloc and release

2019-10-03 Thread Catalin Marinas
On Wed, Oct 02, 2019 at 02:22:48PM -0700, Mark Salyzyn wrote: > Some drivers can not be turned into a module without cma_alloc and > cma_release exported. Examples include ion, and we also found some > out of tree infiniband and camera drivers. > > Signed-off-by: Mark Salyzyn > Cc: kernel-t...@a

[PATCH] mm: export cma alloc and release

2019-10-02 Thread Mark Salyzyn
Some drivers can not be turned into a module without cma_alloc and cma_release exported. Examples include ion, and we also found some out of tree infiniband and camera drivers. Signed-off-by: Mark Salyzyn Cc: kernel-t...@android.com Cc: linux-kernel@vger.kernel.org --- mm/cma.c | 2 ++ 1 file c