Re: [PATCH] mm: compaction: fix the page state calculation in too_many_isolated

2015-01-22 Thread Vlastimil Babka
On 01/22/2015 01:58 AM, David Rientjes wrote: I think in case of async compaction, we could skip the safe stuff and just terminate it - it's already done when too_many_isolated returns true, and there's no congestion waiting in that case. So you could extend the too_many_isolated() with "safe" p

Re: [PATCH] mm: compaction: fix the page state calculation in too_many_isolated

2015-01-21 Thread David Rientjes
On Wed, 21 Jan 2015, Vlastimil Babka wrote: > On 01/21/2015 10:34 AM, Vinayak Menon wrote: > > Commit "3611badc1baa" (mm: vmscan: fix the page state calculation in > > That appears to be a -next commit ID, which won't be the same in Linus' tree, > so > it shouldn't be in commit message, AFAIK. >

Re: [PATCH] mm: compaction: fix the page state calculation in too_many_isolated

2015-01-21 Thread Vlastimil Babka
On 01/21/2015 10:34 AM, Vinayak Menon wrote: > Commit "3611badc1baa" (mm: vmscan: fix the page state calculation in That appears to be a -next commit ID, which won't be the same in Linus' tree, so it shouldn't be in commit message, AFAIK. > too_many_isolated) fixed an issue where a number of task

[PATCH] mm: compaction: fix the page state calculation in too_many_isolated

2015-01-21 Thread Vinayak Menon
Commit "3611badc1baa" (mm: vmscan: fix the page state calculation in too_many_isolated) fixed an issue where a number of tasks were blocked in reclaim path for seconds, because of vmstat_diff not being synced in time. A similar problem can happen in isolate_migratepages_block, similar calculation i