Re: [PATCH] mm: change size_t to unsigned int for cma_alloc

2021-03-30 Thread David Hildenbrand
On 30.03.21 17:00, Minchan Kim wrote: On Tue, Mar 30, 2021 at 09:58:37AM +0200, David Hildenbrand wrote: On 29.03.21 22:12, Minchan Kim wrote: On Mon, Mar 29, 2021 at 07:44:31PM +0100, Matthew Wilcox wrote: On Mon, Mar 29, 2021 at 11:25:53AM -0700, Minchan Kim wrote: size_t in cma_alloc is co

Re: [PATCH] mm: change size_t to unsigned int for cma_alloc

2021-03-30 Thread Minchan Kim
On Tue, Mar 30, 2021 at 09:58:37AM +0200, David Hildenbrand wrote: > On 29.03.21 22:12, Minchan Kim wrote: > > On Mon, Mar 29, 2021 at 07:44:31PM +0100, Matthew Wilcox wrote: > > > On Mon, Mar 29, 2021 at 11:25:53AM -0700, Minchan Kim wrote: > > > > size_t in cma_alloc is confusing since it makes p

Re: [PATCH] mm: change size_t to unsigned int for cma_alloc

2021-03-30 Thread David Hildenbrand
On 29.03.21 22:12, Minchan Kim wrote: On Mon, Mar 29, 2021 at 07:44:31PM +0100, Matthew Wilcox wrote: On Mon, Mar 29, 2021 at 11:25:53AM -0700, Minchan Kim wrote: size_t in cma_alloc is confusing since it makes people think it's byte count, not pages. Fix it. i think it has to be unsigned lon

Re: [PATCH] mm: change size_t to unsigned int for cma_alloc

2021-03-29 Thread Minchan Kim
On Mon, Mar 29, 2021 at 07:44:31PM +0100, Matthew Wilcox wrote: > On Mon, Mar 29, 2021 at 11:25:53AM -0700, Minchan Kim wrote: > > size_t in cma_alloc is confusing since it makes people think > > it's byte count, not pages. Fix it. > > i think it has to be unsigned long. > > 67a2e213e7e937c41c52a

Re: [PATCH] mm: change size_t to unsigned int for cma_alloc

2021-03-29 Thread Matthew Wilcox
On Mon, Mar 29, 2021 at 11:25:53AM -0700, Minchan Kim wrote: > size_t in cma_alloc is confusing since it makes people think > it's byte count, not pages. Fix it. i think it has to be unsigned long. 67a2e213e7e937c41c52ab5bc46bf3f4de469f6e > Link: > https://lore.kernel.org/linux-mm/2021032404343

[PATCH] mm: change size_t to unsigned int for cma_alloc

2021-03-29 Thread Minchan Kim
size_t in cma_alloc is confusing since it makes people think it's byte count, not pages. Fix it. Link: https://lore.kernel.org/linux-mm/20210324043434.gp1719...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Minchan Kim --- include/linux/cma.h | 2 +- mm/cma.c| 8