Re: [PATCH] mm: change may_enter_fs check condition

2015-11-15 Thread yalin wang
> On Nov 13, 2015, at 23:36, Michal Hocko wrote: > > On Fri 13-11-15 13:01:16, Vlastimil Babka wrote: >> On 11/13/2015 12:47 PM, yalin wang wrote: >>> Add page_is_file_cache() for __GFP_FS check, >>> otherwise, a Pageswapcache() && PageDirty() page can always be write >>> back if the gfp flag is

Re: [PATCH] mm: change may_enter_fs check condition

2015-11-13 Thread Michal Hocko
On Fri 13-11-15 13:01:16, Vlastimil Babka wrote: > On 11/13/2015 12:47 PM, yalin wang wrote: > >Add page_is_file_cache() for __GFP_FS check, > >otherwise, a Pageswapcache() && PageDirty() page can always be write > >back if the gfp flag is __GFP_FS, this is not the expected behavior. > > I'm not s

Re: [PATCH] mm: change may_enter_fs check condition

2015-11-13 Thread Vlastimil Babka
On 11/13/2015 12:47 PM, yalin wang wrote: Add page_is_file_cache() for __GFP_FS check, otherwise, a Pageswapcache() && PageDirty() page can always be write back if the gfp flag is __GFP_FS, this is not the expected behavior. I'm not sure I understand your point correctly *), but you seem to imp

[PATCH] mm: change may_enter_fs check condition

2015-11-13 Thread yalin wang
Add page_is_file_cache() for __GFP_FS check, otherwise, a Pageswapcache() && PageDirty() page can always be write back if the gfp flag is __GFP_FS, this is not the expected behavior. Signed-off-by: yalin wang --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/