Re: [PATCH] mm: Refactor readahead defines in mm.h

2018-12-21 Thread David Hildenbrand
On 21.12.18 15:40, Nikolay Borisov wrote: > All users of VM_MAX_READAHEAD actually convert it to kbytes and then to > pages. Define the macro explicitly as (SZ_128K / PAGE_SIZE). This > simplifies the expression in every filesystem. Also rename the macro to > VM_READAHEAD_PAGES to properly convey i

Re: [PATCH] mm: Refactor readahead defines in mm.h

2018-12-21 Thread Matthew Wilcox
On Fri, Dec 21, 2018 at 04:40:53PM +0200, Nikolay Borisov wrote: > All users of VM_MAX_READAHEAD actually convert it to kbytes and then to > pages. Define the macro explicitly as (SZ_128K / PAGE_SIZE). This > simplifies the expression in every filesystem. Also rename the macro to > VM_READAHEAD_PAG

[PATCH] mm: Refactor readahead defines in mm.h

2018-12-21 Thread Nikolay Borisov
All users of VM_MAX_READAHEAD actually convert it to kbytes and then to pages. Define the macro explicitly as (SZ_128K / PAGE_SIZE). This simplifies the expression in every filesystem. Also rename the macro to VM_READAHEAD_PAGES to properly convey its meaning. Finally remove unused VM_MIN_READAHEAD