Re: [PATCH] mm: Reduce memory bloat with THP

2017-12-18 Thread Peter Zijlstra
On Fri, Dec 15, 2017 at 11:04:03PM -0800, Nitin Gupta wrote: > >> Orabug: 26910556 > > > > Wat? > > > > It's oracle internal identifier used to track this work. And as such has no place what so ever outside of oracle. Do not include junk like that in upstream patches.

Re: [PATCH] mm: Reduce memory bloat with THP

2017-12-15 Thread Nitin Gupta
On 12/15/17 2:01 AM, Kirill A. Shutemov wrote: > On Thu, Dec 14, 2017 at 05:28:52PM -0800, Nitin Gupta wrote: >> diff --git a/mm/madvise.c b/mm/madvise.c >> index 751e97a..b2ec07b 100644 >> --- a/mm/madvise.c >> +++ b/mm/madvise.c >> @@ -508,6 +508,7 @@ static long madvise_dontneed_single_vma(struc

Re: [PATCH] mm: Reduce memory bloat with THP

2017-12-15 Thread Nitin Gupta
On 12/15/17 2:00 AM, Kirill A. Shutemov wrote: > On Thu, Dec 14, 2017 at 05:28:52PM -0800, Nitin Gupta wrote: >> Currently, if the THP enabled policy is "always", or the mode >> is "madvise" and a region is marked as MADV_HUGEPAGE, a hugepage >> is allocated on a page fault if the pud or pmd is emp

Re: [PATCH] mm: Reduce memory bloat with THP

2017-12-15 Thread Kirill A. Shutemov
On Thu, Dec 14, 2017 at 05:28:52PM -0800, Nitin Gupta wrote: > diff --git a/mm/madvise.c b/mm/madvise.c > index 751e97a..b2ec07b 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -508,6 +508,7 @@ static long madvise_dontneed_single_vma(struct > vm_area_struct *vma, >

Re: [PATCH] mm: Reduce memory bloat with THP

2017-12-15 Thread Kirill A. Shutemov
On Thu, Dec 14, 2017 at 05:28:52PM -0800, Nitin Gupta wrote: > Currently, if the THP enabled policy is "always", or the mode > is "madvise" and a region is marked as MADV_HUGEPAGE, a hugepage > is allocated on a page fault if the pud or pmd is empty. This > yields the best VA translation performan