Re: [PATCH] mm: More __meminit annotations.

> But then what > might happen is that everybody would think his particular use of inline > is correct and beneficial and all users of inline in kernel would end up > as __always_inline anyway. You miss that there is a big difference between "beneficial" and "needs". The latter is used when some

Re: [PATCH] mm: More __meminit annotations.

Hi, On 6/18/07, Sam Ravnborg <[EMAIL PROTECTED]> wrote: On Mon, Jun 18, 2007 at 02:49:24PM +0900, Yasunori Goto wrote: > > } > > > > -static inline unsigned long zone_absent_pages_in_node(int nid, > > +static inline unsigned long __meminit zone_absent_pages_in_node(int nid, > >

Re: [PATCH] mm: More __meminit annotations.

On Mon, Jun 18, 2007 at 12:58:34PM +0530, Satyam Sharma wrote: > > Actually, modpost will _not_ complain precisely _because_ kernel > uses always_inline so a separate body for the function will never be > emitted at all. That has been threaten to change many times. Far far far too much are marked

Re: [PATCH] mm: More __meminit annotations.

On Mon, Jun 18, 2007 at 02:49:24PM +0900, Yasunori Goto wrote: > > } > > > > -static inline unsigned long zone_absent_pages_in_node(int nid, > > +static inline unsigned long __meminit zone_absent_pages_in_node(int nid, > > unsigned long zone_type, > >

Re: [PATCH] mm: More __meminit annotations.

On 6/18/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: Hi, On 6/18/07, Yasunori Goto <[EMAIL PROTECTED]> wrote: > > On Mon, Jun 18, 2007 at 02:49:24PM +0900, Yasunori Goto wrote: > > > > -static inline unsigned long zone_absent_pages_in_node(int nid, > > > > +static inline unsigned long __meminit

Re: [PATCH] mm: More __meminit annotations.

Hi, On 6/18/07, Yasunori Goto <[EMAIL PROTECTED]> wrote: > On Mon, Jun 18, 2007 at 02:49:24PM +0900, Yasunori Goto wrote: > > > -static inline unsigned long zone_absent_pages_in_node(int nid, > > > +static inline unsigned long __meminit zone_absent_pages_in_node(int nid, > > >

Re: [PATCH] mm: More __meminit annotations.

> On Mon, Jun 18, 2007 at 02:49:24PM +0900, Yasunori Goto wrote: > > > -static inline unsigned long zone_absent_pages_in_node(int nid, > > > +static inline unsigned long __meminit zone_absent_pages_in_node(int nid, > > > unsigned long zone_type, > > >

Re: [PATCH] mm: More __meminit annotations.

On Mon, Jun 18, 2007 at 02:49:24PM +0900, Yasunori Goto wrote: > > -static inline unsigned long zone_absent_pages_in_node(int nid, > > +static inline unsigned long __meminit zone_absent_pages_in_node(int nid, > > unsigned long zone_type, > >

Re: [PATCH] mm: More __meminit annotations.

Thanks for your checking. > -void zone_init_free_lists(struct pglist_data *pgdat, struct zone *zone, > - unsigned long size) > +static void __meminit zone_init_free_lists(struct pglist_data *pgdat, > + struct zone *zone, unsigned long size) >

[PATCH] mm: More __meminit annotations.

Currently zone_spanned_pages_in_node() and zone_absent_pages_in_node() are non-static for ARCH_POPULATES_NODE_MAP and static otherwise. However, only the non-static versions are __meminit annotated, despite only being called from __meminit functions in either case. zone_init_free_lists() is curren