Re: [PATCH] mm: Do not use double negation for testing page flags

2017-03-08 Thread Minchan Kim
Hi Vlastimil, On Wed, Mar 08, 2017 at 08:51:23AM +0100, Vlastimil Babka wrote: > On 03/08/2017 06:25 AM, Minchan Kim wrote: > > Hi Anshuman, > > > > On Tue, Mar 07, 2017 at 09:31:18PM +0530, Anshuman Khandual wrote: > >> On 03/07/2017 12:06 PM, Minchan Kim wrote: > >>> With the discussion[1], I f

Re: [PATCH] mm: Do not use double negation for testing page flags

2017-03-08 Thread Michal Hocko
On Wed 08-03-17 08:51:23, Vlastimil Babka wrote: > On 03/08/2017 06:25 AM, Minchan Kim wrote: [...] > > Although we can add a little description > > somewhere in page-flags.h, I believe changing to boolean is more > > clear/not-error-prone so Chen's work is enough worth, I think. > > Agree, unless

Re: [PATCH] mm: Do not use double negation for testing page flags

2017-03-08 Thread Vlastimil Babka
On 03/08/2017 06:25 AM, Minchan Kim wrote: > Hi Anshuman, > > On Tue, Mar 07, 2017 at 09:31:18PM +0530, Anshuman Khandual wrote: >> On 03/07/2017 12:06 PM, Minchan Kim wrote: >>> With the discussion[1], I found it seems there are every PageFlags >>> functions return bool at this moment so we don't

Re: [PATCH] mm: Do not use double negation for testing page flags

2017-03-07 Thread Minchan Kim
Hi Anshuman, On Tue, Mar 07, 2017 at 09:31:18PM +0530, Anshuman Khandual wrote: > On 03/07/2017 12:06 PM, Minchan Kim wrote: > > With the discussion[1], I found it seems there are every PageFlags > > functions return bool at this moment so we don't need double > > negation any more. > > Although i

Re: [PATCH] mm: Do not use double negation for testing page flags

2017-03-07 Thread Johannes Weiner
On Tue, Mar 07, 2017 at 03:36:37PM +0900, Minchan Kim wrote: > With the discussion[1], I found it seems there are every PageFlags > functions return bool at this moment so we don't need double > negation any more. > Although it's not a problem to keep it, it makes future users > confused to use dob

Re: [PATCH] mm: Do not use double negation for testing page flags

2017-03-07 Thread Anshuman Khandual
On 03/07/2017 12:06 PM, Minchan Kim wrote: > With the discussion[1], I found it seems there are every PageFlags > functions return bool at this moment so we don't need double > negation any more. > Although it's not a problem to keep it, it makes future users > confused to use dobule negation for t

[PATCH] mm: Do not use double negation for testing page flags

2017-03-07 Thread Minchan Kim
With the discussion[1], I found it seems there are every PageFlags functions return bool at this moment so we don't need double negation any more. Although it's not a problem to keep it, it makes future users confused to use dobule negation for them, too. Remove such possibility. [1] https://marc