Re: [PATCH] mm/zpool: use prefixed module loading

2014-08-12 Thread Kees Cook
On Fri, Aug 8, 2014 at 8:08 PM, Herbert Xu wrote: > On Fri, Aug 08, 2014 at 05:06:41PM -0700, Kees Cook wrote: >> >> I think we need to fix zswap now before it gets too far, and likely >> adjust the crypto API to use a module prefix as well. Perhaps we need >> a "crypto-" prefix? > > Yes I think a

Re: [PATCH] mm/zpool: use prefixed module loading

2014-08-11 Thread Dan Streetman
Ok if the crypto request_module is changed it makes more sense to change zpool's use of request_module; it looks like there are a couple other places in the kernel using prefixes/aliases (although it's not universal). I still suggest moving the MODULE_ALIAS() into zbud/zsmalloc's #ifdef CONFIG_ZPO

Re: [PATCH] mm/zpool: use prefixed module loading

2014-08-09 Thread Greg KH
On Fri, Aug 08, 2014 at 05:06:41PM -0700, Kees Cook wrote: > On Fri, Aug 8, 2014 at 10:11 AM, Dan Streetman wrote: > > On Fri, Aug 8, 2014 at 3:53 AM, Kees Cook wrote: > >> To avoid potential format string expansion via module parameters, > >> do not use the zpool type directly in request_module(

Re: [PATCH] mm/zpool: use prefixed module loading

2014-08-08 Thread Herbert Xu
On Fri, Aug 08, 2014 at 05:06:41PM -0700, Kees Cook wrote: > > I think we need to fix zswap now before it gets too far, and likely > adjust the crypto API to use a module prefix as well. Perhaps we need > a "crypto-" prefix? Yes I think a crypto- prefix would make sense. Most crypto algorithms sh

Re: [PATCH] mm/zpool: use prefixed module loading

2014-08-08 Thread Dan Streetman
On Fri, Aug 8, 2014 at 8:06 PM, Kees Cook wrote: > On Fri, Aug 8, 2014 at 10:11 AM, Dan Streetman wrote: >> On Fri, Aug 8, 2014 at 3:53 AM, Kees Cook wrote: >>> To avoid potential format string expansion via module parameters, >>> do not use the zpool type directly in request_module() without a

Re: [PATCH] mm/zpool: use prefixed module loading

2014-08-08 Thread Kees Cook
On Fri, Aug 8, 2014 at 10:11 AM, Dan Streetman wrote: > On Fri, Aug 8, 2014 at 3:53 AM, Kees Cook wrote: >> To avoid potential format string expansion via module parameters, >> do not use the zpool type directly in request_module() without a >> format string. Additionally, to avoid arbitrary modu

Re: [PATCH] mm/zpool: use prefixed module loading

2014-08-08 Thread Seth Jennings
On Fri, Aug 08, 2014 at 01:11:55PM -0400, Dan Streetman wrote: > On Fri, Aug 8, 2014 at 3:53 AM, Kees Cook wrote: > > To avoid potential format string expansion via module parameters, > > do not use the zpool type directly in request_module() without a > > format string. Additionally, to avoid arb

Re: [PATCH] mm/zpool: use prefixed module loading

2014-08-08 Thread Dan Streetman
On Fri, Aug 8, 2014 at 3:53 AM, Kees Cook wrote: > To avoid potential format string expansion via module parameters, > do not use the zpool type directly in request_module() without a > format string. Additionally, to avoid arbitrary modules being loaded > via zpool API (e.g. via the zswap_zpool_t

Re: [PATCH] mm/zpool: use prefixed module loading

2014-08-08 Thread Seth Jennings
On Fri, Aug 08, 2014 at 12:53:16AM -0700, Kees Cook wrote: > To avoid potential format string expansion via module parameters, > do not use the zpool type directly in request_module() without a > format string. Additionally, to avoid arbitrary modules being loaded > via zpool API (e.g. via the zswa

[PATCH] mm/zpool: use prefixed module loading

2014-08-08 Thread Kees Cook
To avoid potential format string expansion via module parameters, do not use the zpool type directly in request_module() without a format string. Additionally, to avoid arbitrary modules being loaded via zpool API (e.g. via the zswap_zpool_type module parameter) add a "zpool-" prefix to the request