Re: [PATCH] mm/z3fold.c: Fix race between migration and destruction

2019-08-10 Thread Vitaly Wool
Hi Henry, Den fre 9 aug. 2019 6:46 emHenry Burns skrev: > > In z3fold_destroy_pool() we call destroy_workqueue(&pool->compact_wq). > However, we have no guarantee that migration isn't happening in the > background at that time. > > Migration directly calls queue_work_on(pool->compact_wq), if dest

Re: [PATCH] mm/z3fold.c: Fix race between migration and destruction

2019-08-09 Thread Henry Burns
I've just CC'd a personal email here so that I can respond to any replies after today. On Fri, Aug 9, 2019 at 9:46 AM Henry Burns wrote: > > In z3fold_destroy_pool() we call destroy_workqueue(&pool->compact_wq). > However, we have no guarantee that migration isn't happening in the > background at

[PATCH] mm/z3fold.c: Fix race between migration and destruction

2019-08-09 Thread Henry Burns
In z3fold_destroy_pool() we call destroy_workqueue(&pool->compact_wq). However, we have no guarantee that migration isn't happening in the background at that time. Migration directly calls queue_work_on(pool->compact_wq), if destruction wins that race we are using a destroyed workqueue. Signed-of